simple-sonoff-server icon indicating copy to clipboard operation
simple-sonoff-server copied to clipboard

Published 20 hours ago • verified publisher icon mdopp

device.messages may contain stale messages

Open PKGeorgiev opened this issue 6 years ago • 2 comments

In situations where a registered sonoff device becomes offline or it was unable to acknowledge a packet due to intermittent wifi drop, the message will remain in device.messages forever.

Since message.sequence is a timestamp, a periodic timer could be implemented to clear stale messages (older than X minutes for example).

I have two more questions:

  1. What happens to devices that were not alive more than X minutes? Are they removed from devices list?
  2. Shouldn't the API server return an error code when you try to control a device that is not currently active?

PKGeorgiev avatar Mar 08 '18 13:03 PKGeorgiev

Hi, enhancements are welcome!

About the "remove when inactive" => the devices do not send keep-alives, hence we would have to implement the other way around and the server has to send keep-alive-checks. And yes, it should return an error, when the device is not active! good point

mdopp avatar Mar 08 '18 14:03 mdopp

Are you going to realize the stale message removal strategy using a timer?

PKGeorgiev avatar Mar 29 '18 09:03 PKGeorgiev