pyoptsparse icon indicating copy to clipboard operation
pyoptsparse copied to clipboard

Updating minimum dependency requirements

Open marcomangano opened this issue 1 year ago • 3 comments

Purpose

Issues like #387 show that the current minimum dependency versions are out of date - even considering our own stencil of supported dependencies. I updated the minimum numpy and scipy versions to our stable set of dependencies.

However, I think we should also update the mdolab-baseclasses version and, more importantly, the minimum python version. The code itself is not changing but this would create issues for the users who are still relying on older python environments.

@nwu63 suggests to adopt the NEP29 (or the more recent SPEC 0 policy) to avoid this issue, but I think at that point we should extend this to the whole organization packages. I want to hear @eirikurj take as well as he has been working on a way to map these dependencies over time.

Expected time until merged

1 day if we are ok with only updating numpy and scipy

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [x] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [ ] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation

marcomangano avatar Feb 27 '24 19:02 marcomangano

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.10%. Comparing base (01d5111) to head (c932ec9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files          22       22           
  Lines        3290     3290           
=======================================
  Hits         2438     2438           
  Misses        852      852           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 27 '24 19:02 codecov[bot]

@marcomangano just to formally respond and for future reference. I am in favor of SPEC 0 for our codebase. We have been discussing this in https://github.com/mdolab/docker/issues/241 and should continue there.

eirikurj avatar Feb 29 '24 15:02 eirikurj

Bumped the minor version since the minimum version update could potentially be a breaking change?

marcomangano avatar Mar 26 '24 14:03 marcomangano

@sseraj @lamkina @eirikurj can you check this out to see if got the right package versions? We should merge ASAP and make a new release.

marcomangano avatar Apr 24 '24 18:04 marcomangano