pygeo icon indicating copy to clipboard operation
pygeo copied to clipboard

Adding MPhys 2.0 support

Open timryanb opened this issue 9 months ago • 1 comments

Purpose

This PR adds support for MPhys 2.0. This update requires the following minor breaking change to previous MPhys 1.0 scripts: rather than passing the discipline as a str argument to nom_add_discipline_coords

self.geometry.nom_add_discipline_coords("aero", points)

The discipline is now defined by passing an MPhys Geometry class from the variable convention module

self.geometry.nom_add_discipline_coords(MPhysVariables.Aerodynamics.Surface.Geometry, points)

Expected time until merged

A month

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [ ] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [ ] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation

timryanb avatar Mar 27 '25 14:03 timryanb

Codecov Report

:x: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.00%. Comparing base (4b35520) to head (7b6cd90). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pygeo/mphys/mphys_dvgeo.py 18.18% 9 Missing :warning:

:x: Your patch status has failed because the patch coverage (18.18%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   67.01%   67.00%   -0.02%     
==========================================
  Files          47       47              
  Lines       12327    12331       +4     
==========================================
+ Hits         8261     8262       +1     
- Misses       4066     4069       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 27 '25 14:03 codecov[bot]

Docs build failure should be fixed by https://github.com/mdolab/sphinx_mdolab_theme/pull/17

A-CGray avatar Jul 02 '25 20:07 A-CGray

@ArshSaja can you please review this?

A-CGray avatar Aug 28 '25 20:08 A-CGray

Changes look good to me

ArshSaja avatar Sep 17 '25 18:09 ArshSaja