pygeo
pygeo copied to clipboard
Various small changes
Purpose
- Changes the hard-coded lower bound for the triangulated surface constraint from a dummy value of
-1e10
toNone
which is the correct way to represent that there is no lower bound. - Converts the SVD vectors computed when using composite DVs from a numpy matrix to a numpy array. Using a matrix causes the design variable values to end up as a 2D array which causes pyoptsparse to fail.
- Fixes a check in
addRefAxis
that is supposed to evaluate to false is x/y/zFraction is None, but currently also evaluates to False is the values are zero.
Expected time until merged
Type of change
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (non-backwards-compatible fix or feature)
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Documentation update
- [ ] Maintenance update
- [ ] Other (please describe)
Testing
Checklist
- [ ] I have run
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formatted - [ ] I have formatted the Fortran code with
fprettify
or C/C++ code withclang-format
as applicable - [ ] I have run unit and regression tests which pass locally with my changes
- [ ] I have added new tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.47%. Comparing base (
20f491a
) to head (1707057
). Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 65.47% 65.47%
=======================================
Files 47 47
Lines 12265 12265
=======================================
Hits 8030 8030
Misses 4235 4235
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.