openconcept icon indicating copy to clipboard operation
openconcept copied to clipboard

Fix the failing GitHub Actions

Open eytanadler opened this issue 9 months ago • 1 comments

Purpose

Fix the GitHub Actions failures on the MacOS builds when setting up Python.

SciPy 1.6.0 wasn't working on the ARM Mac builds, so I've bumped the minimum SciPy version from 1.6.0 to 1.7.0, which now works correctly.

Finally, this has some minor codecov changes that seem to work better now (the main changes were a new token in the OpenConcept secrets and bumping the codecov action to version 4).

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)

eytanadler avatar May 09 '24 20:05 eytanadler

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.08%. Comparing base (ed14c54) to head (63eecf4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         103      103           
  Lines       10717    10717           
=======================================
  Hits         8797     8797           
  Misses       1920     1920           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 20:05 codecov[bot]

@eytanadler is this ready for a review? The checks are hanging, but it seems that might be what this PR is addressing?

lamkina avatar May 14 '24 19:05 lamkina

Yes it's ready. The checks are hanging because they changed name (1.6.0 -> 1.7.0), so the required ones I have setup are no longer valid. If you're good with these changes I can fix it

eytanadler avatar May 14 '24 20:05 eytanadler