Clear out compiler warnings and remarks

[anilyil]

Type of issue

• Code formatting

Description

We have a bunch of warnings and remarks generated during compilation of ADflow. PR #52 addresses most of these issues; however, we still have some warnings remaining:

1. Complex builds still complain about missing modules. @nwu63 and I will work on this with the PR #52.
2. The forces array is defined as an output variable with the getForces_b routine, but is not used. I did not modify this now, but we can edit the call signature and/or modify the intent. The warning looks like this:

../warping/getForces.F90(124): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [FORCES]

3. With intel compilers, we get a lot of remarks about output formats from fortran files. These remarks look like this:

remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.

Here is the explanation of this from doctor fortran himself: https://software.intel.com/en-us/forums/intel-fortran-compiler/topic/635137 This can be easily fixed, but we need to check if all outputs look okay after the fix. 4. There are a bunch of warnings generated by the f2py wrapping. These contain:

warning #1224: #warning directive: "Using deprecated NumPy API, disable it by "          "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

and a bunch of

libadflowmodule.c(11948): warning #556: a value of type "void (*)(int *, int *, void (*)(char *, int *), int *)" cannot be assigned to an entity of type "f2py_init_func"
    f2py_communication_def[i_f2py++].func = sendrequests;

[sseraj]

4. Additional f2py warnings include: getarrdims:warning: assumed shape array, using 0 instead of ':' and warning: assignment from incompatible pointer type

[ewu63]

The NPY_NO_DEPRECATED_API stuff is due Cython/Numpy which should get fixed at some point, but in the mean time it's fine to leave the harmless messages in. See here for more details.