adflow icon indicating copy to clipboard operation
adflow copied to clipboard

Surface output for forces in lift and drag directions

Open sseraj opened this issue 1 year ago • 1 comments

Purpose

This PR adds force coefficients per unit area projected in the lift and drag directions as surface output variables. Here is an example of the force in the drag direction for the MACH tutorial wing case: force_in_drag_dir

It would be great if the reviewers could test this on their own cases.

Expected time until merged

2-3 weeks

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [ ] Maintenance update
  • [ ] Other (please describe)

Testing

No tests, but I tried this on wing and full aircraft cases and the outputs made sense.

Checklist

  • [x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [x] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [x] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation

sseraj avatar May 31 '24 18:05 sseraj

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.02%. Comparing base (20ff867) to head (f0958fd). Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files          13       13           
  Lines        4119     4119           
=======================================
  Hits         1690     1690           
  Misses       2429     2429           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 31 '24 18:05 codecov[bot]

@sanjan98 and I will take a look soon. I believe it is time to make a new release for ADflow. There are no breaking changes here, right @sseraj ? Likely a patch release will be enough.

marcomangano avatar Oct 07 '24 15:10 marcomangano

That's right, there are no breaking changes in this PR. There have been some breaking changes since the last release though, like #330 and #359 to some extent.

sseraj avatar Oct 08 '24 04:10 sseraj

Ok, so we should go for a minor release overall, given all these changes since the latest one. We can wait for #362 to be merged since it's minor and should be ready by the end of the week. If @lamkina is ok we can bump the minor (?) version here in the meantime?

marcomangano avatar Oct 08 '24 16:10 marcomangano

I think bumping the minor version here makes sense. #362 is just adding tests so I don't think it needs to be factored into the version bump.

lamkina avatar Oct 08 '24 16:10 lamkina