Add AeroProblem name to analysis failure solution filenames
Purpose
Failed solutions in the MPhys wrapper currently all use the same baseName. If you are doing multipoint and have separate analyses whose solutions fail, they will overwrite each other. For example, the first cruise analysis failure file would be called "analysis_fail_000_surf.plt". If a top of climb case later fails, it will write a file with the same name, overwriting the cruise failure.
This PR adds the AeroProblem name to the failed solution file name, so instead of "analysis_fail_000_surf.plt", it would be "cruise_analysis_fail_000_surf.plt". This fixes the overwriting problem.
Expected time until merged
A day
Type of change
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (non-backwards-compatible fix or feature)
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Documentation update
- [ ] Maintenance update
- [ ] Other (please describe)
Testing
Checklist
- [ ] I have run
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formatted - [ ] I have formatted the Fortran code with
fprettifyor C/C++ code withclang-formatas applicable - [ ] I have run unit and regression tests which pass locally with my changes
- [ ] I have added new tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation
Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 41.45%. Comparing base (
572f2bf) to head (db303c0).
| Files | Patch % | Lines |
|---|---|---|
| adflow/mphys/mphys_adflow.py | 0.00% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 41.47% 41.45% -0.02%
==========================================
Files 13 13
Lines 4068 4069 +1
==========================================
Hits 1687 1687
- Misses 2381 2382 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.