adflow icon indicating copy to clipboard operation
adflow copied to clipboard

Custom pointsets for dvgeo

Open anilyil opened this issue 2 years ago • 4 comments

Purpose

This PR adds the capability to specify custom pointsets based on family names that are tracked separately in DVGeo. Each pointset can receive its own custom kwargs. See the relevant PR in baseclasses for how the custom families are specified: https://github.com/mdolab/baseclasses/pull/89

This is a somewhat complete implementation but there are several assumptions. First, the custom families should not overlap. The implication here comes up with derivative computations; if families overlap, the surface seeds of the overlapped nodes will be double counted.

Second, we assume the custom families span the selected design family, although this is not a hard requirement. We may want to add a check if the provided families actually do span the entire design family.

Expected time until merged

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [ ] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [ ] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation

anilyil avatar Jul 20 '23 18:07 anilyil

Codecov Report

Attention: Patch coverage is 41.07143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 40.90%. Comparing base (20ff867) to head (6f99214).

Files Patch % Lines
adflow/pyADflow.py 41.07% 33 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   41.02%   40.90%   -0.13%     
==========================================
  Files          13       13              
  Lines        4119     4166      +47     
==========================================
+ Hits         1690     1704      +14     
- Misses       2429     2462      +33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 09 '23 02:09 codecov[bot]

Leaving this as a draft PR because after https://github.com/mdolab/adflow/pull/330 is merged, I want to push a small update to this PR that brings similar ptset changes to the changes that come from that other PR.

anilyil avatar Nov 29 '23 09:11 anilyil