adflow icon indicating copy to clipboard operation
adflow copied to clipboard

Separation constraint using surface vector projection

Open ArshSaja opened this issue 2 years ago • 6 comments

Purpose

This PR includes the new separation constraint in ADflow. The previous separation constraint and the new one is available. Each options can be selected through adflow option.

Expected time until merged

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [x] Documentation update
  • [ ] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [x] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [x] I have run unit and regression tests which pass locally with my changes
  • [x] I have added new tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation

ArshSaja avatar Oct 18 '22 19:10 ArshSaja

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.50%. Comparing base (5a885c2) to head (d3b1ce7). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   41.45%   41.50%   +0.04%     
==========================================
  Files          13       13              
  Lines        4069     4069              
==========================================
+ Hits         1687     1689       +2     
+ Misses       2382     2380       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '22 20:10 codecov[bot]

I fixed the merge conflicts and fprettify stuff. @anilyil and @sseraj please review it whenever you have time

ArshSaja avatar Mar 14 '23 19:03 ArshSaja

@anilyil and @sseraj this is ready for your review

ArshSaja avatar Feb 19 '24 17:02 ArshSaja

Thanks for addressing my comments. I have just a couple more

Thanks for the comments @sseraj

ArshSaja avatar Mar 01 '24 16:03 ArshSaja

Thanks for the comments @anilyil

ArshSaja avatar Apr 30 '24 19:04 ArshSaja

@sseraj and @anilyil, the new changes are ready for your review.

ArshSaja avatar May 14 '24 15:05 ArshSaja