adflow icon indicating copy to clipboard operation
adflow copied to clipboard

Working Git Hash for ADflow

Open akleb opened this issue 3 years ago • 3 comments

Purpose

There was concern in this pyspline PR that repos like ADflow would not be able to import the shared object library in the __init__.py file like pyspline because it is normally handled by MExt. I made what seems to me to be a working example here. I think more discussion about specific formatting for this process should be done in the pyspline discussion.

Expected time until merged

a couple weeks, probably want pyspline discussion done first.

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [x] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • [ ] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation

akleb avatar Apr 18 '22 19:04 akleb

Codecov Report

Merging #214 (a10d8ec) into main (99bb3b2) will decrease coverage by 0.58%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   41.35%   40.77%   -0.59%     
==========================================
  Files          13       14       +1     
  Lines        3794     3799       +5     
==========================================
- Hits         1569     1549      -20     
- Misses       2225     2250      +25     
Impacted Files Coverage Δ
adflow/fortranVersion.py 50.00% <50.00%> (ø)
adflow/__init__.py 100.00% <100.00%> (ø)
adflow/pyADflow_C.py 18.64% <0.00%> (-10.17%) :arrow_down:
adflow/pyADflow.py 67.64% <0.00%> (-0.78%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Apr 18 '22 19:04 codecov[bot]

TODOs:

  • [ ] fix the complex build
  • [ ] finalize implementation (based on the pyspline PR)
  • [ ] add printing of the version in the header printed on ADflow call

ewu63 avatar Oct 11 '22 03:10 ewu63

Putting this in draft for now until we converge on https://github.com/mdolab/pyspline/pull/41

eirikurj avatar Nov 07 '22 16:11 eirikurj