adflow icon indicating copy to clipboard operation
adflow copied to clipboard

Using blockettes with non-default simulations should raise an error and quit.

Open anilyil opened this issue 4 years ago • 1 comments

Description of feature

Blockettes only work with steady state RANS simulations with the SA turbulence model on non-rotating reference frames. Any combination of options should automatically disable this feature or rise an error so that these simulations work properly.

Potential solution

We can either raise an error, or automatically disable blockettes when any feature that does not have a blockette implementation is used. This can be done at either pyadflow or fortran level.

I suggest modifying the option on pyADflow level automatically if the user requested one of these options but did not specify blockettes in the runscript. This way, the default will be adjusted automatically and no further action is required. If the user specified blockettes, then we should raise an error and quit.

I will also add a section on blockettes to the documentation so that the developers are aware of this coding approach.

anilyil avatar Jan 20 '21 13:01 anilyil

I am personally onboard with having the code automatically disabling blockettes, as long as we provide a clear "warning" (similar to the one we have/had for the OM wrapper). Given that the blockettes only affect the performance of the solver - if I remember correctly - I don't see the need to throw an error. Thanks for taking care of the documentation, the presentation you made last summer was great but after a few months most of the details are already slipping away.

marcomangano avatar Jan 20 '21 14:01 marcomangano