yari icon indicating copy to clipboard operation
yari copied to clipboard

Add translated-content to recent contributions tile on homepage

Open SphinxKnight opened this issue 3 years ago • 2 comments

Summary

I have discovered the "Recent contributions" tile on the homepage from the redesign and I like how it exposes the open source nature of MDN.

Problem

However, there were no reference of https://github.com/mdn/translated-content/ :(

Solution

Hack the thing so that contributions from mdn/translated-content are visible as well

Screenshots

Before

image

After

image

How did you test this change?

Ran it locally.

cc @mdn/localization-team-leads / @mdn/mdn-community-engagement

SphinxKnight avatar Sep 28 '22 04:09 SphinxKnight

Thank you for this @SphinxKnight, I for one support this idea.

schalkneethling avatar Sep 28 '22 12:09 schalkneethling

I remember some about this in te matrix channel BTW it's awesome! Thank you so much!

Graywolf9 avatar Sep 28 '22 15:09 Graywolf9

We will have to defer this to the product team, because they "own" the homepage.

Maybe we could show different "Recent contributions" depending on the locale:

  • https://developer.mozilla.org/en-US would show only content PRs.
  • https://developer.mozilla.org/fr would show additonally/instead French translated-content PRs (tagged with l10n-fr label).

caugner avatar Oct 19 '22 18:10 caugner

Maybe we could show different "Recent contributions" depending on the locale:

Why should contributions be divided depending on the locale?

SphinxKnight avatar Oct 20 '22 13:10 SphinxKnight

We have discussed this internally and have aligned on showing the last 5 contributions from mdn/content and the last 5 contributions from mdn/translated-content together. 🎉

caugner avatar Oct 20 '22 18:10 caugner

Thanks a lot for the review @caugner, I'll take care of fixing those today or tomorrow.

SphinxKnight avatar Oct 24 '22 09:10 SphinxKnight

Thank you @SphinxKnight! 🎉

caugner avatar Oct 25 '22 18:10 caugner