yari icon indicating copy to clipboard operation
yari copied to clipboard

fix(content/document): let `roots` as rest parameters of read

Open yin1999 opened this issue 2 years ago • 1 comments

Summary

Fixes: #7196.

Problem

~It seems that the findByURL doesn't pass roots as a string array. Just fix this.~ refeactor the read function: pass roots as rest parameters.

And for the remove function, we can search with the specific root (not both en-us and l10n). And we can throw error when the locale is not specified (or not exists).

Solution

Minor fixes.


Screenshots

Before

for en-US (yarn tool delete Web/API/ShadowRoot/onslotchange --redirect=Web/API/HTMLSlotElement/slotchange_event)

image

for fr (yarn tool delete conflicting/Glossary/Firefox_OS fr --redirect Glossary/Boot2Gecko)

image

After

for en-US:

image

for fr:

image


How did you test this change?

run yarn tool delete

yin1999 avatar Sep 20 '22 00:09 yin1999

is there something blocking this one? using the command is almost a mandatory step to deal with sync translated content PRs

SphinxKnight avatar Oct 07 '22 11:10 SphinxKnight