yari icon indicating copy to clipboard operation
yari copied to clipboard

Published 20 hours ago • verified publisher icon mdn

feat: add `noreferrer` and `target=_blank` to external link for built contents

Open yoshinorin opened this issue 1 year ago • 2 comments

Summary

As is a title.

Problem

An external link in contents that are built by build/index.js hasn't noreferrer and target=_blank.

Solution

Add noreferrer and target=_blank to external link built by build/index.js.

Screenshots

Before

before

After

after

How did you test this change?

  1. Change the source core.
  2. Run locally
  3. Check manually

Thank you :)

yoshinorin avatar Aug 15 '22 12:08 yoshinorin

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Aug 29 '22 17:08 github-actions[bot]

May I rebase this?

yoshinorin avatar Sep 13 '22 14:09 yoshinorin

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Nov 22 '22 09:11 github-actions[bot]

Thank you for your PR and sorry for the long wait! 🙏

In the mean-time, we have landed target="_blank" in https://github.com/mdn/yari/pull/7640.

We have omitted noreferrer intentionally, so that our partners (and other sites) can identify traffic coming from MDN.

caugner avatar Nov 30 '22 23:11 caugner