yari icon indicating copy to clipboard operation
yari copied to clipboard

Table missing headings on mobile

Open sybereal opened this issue 2 years ago • 9 comments

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#cache_directives

What information was incorrect, unhelpful, or incomplete?

The table juxtaposing request and response directives is missing its headings on mobile: Screenshot_20220611-130937_Chrome

In desktop view for comparison: Screenshot_20220611-131420_Chrome

What did you expect to see?

Table headings should be displayed on all platforms.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
  • Folder: en-us/web/http/headers/cache-control
  • MDN URL: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
  • GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/http/headers/cache-control/index.md
  • Last commit: https://github.com/mdn/content/commit/88ad012e4e0f72ef22ffc4c97f2bef4734a35167
  • Document last modified: 2022-05-01T05:16:41.000Z

sybereal avatar Jun 11 '22 11:06 sybereal

I had a look at the source. The rule causing this is:

@media screen and (max-width: 425px) {
  thead {
    display: none;
  }
}

in index-mobile.scss.

This seems intentional, but I'm unsure about the reasoning behind it.

This should be moved to https://github.com/mdn/yari

mikoMK avatar Jun 11 '22 19:06 mikoMK

@schalkneethling I think you need to transfer this to mdn/yari.

teoli2003 avatar Jun 11 '22 20:06 teoli2003

May I work on this?

rushikeshadhav avatar Jun 16 '22 15:06 rushikeshadhav

May I work on this?

Sure thing! Thank you for offering.

schalkneethling avatar Jun 16 '22 22:06 schalkneethling

I had a look at the source. The rule causing this is:

@media screen and (max-width: 425px) {
  thead {
    display: none;
  }
}

in index-mobile.scss.

This seems intentional, but I'm unsure about the reasoning behind it.

This should be moved to https://github.com/mdn/yari

Hey, can you state the path? I am unable to locate the file path of index-mobile.scss

rushikeshadhav avatar Jun 18 '22 16:06 rushikeshadhav

It's here: https://github.com/mdn/yari/blob/main/client/src/document/ingredients/browser-compatibility-table/index-mobile.scss

It was introduce with PR #5648. So it would probably make sense to change the selector to .bc-table thead to keep the code for the browser compatibility table.

mikoMK avatar Jun 19 '22 02:06 mikoMK

I am getting this error after following all the steps of Verifying commit signatures Can anyone help me fix this? after running this $ git commit -S -m "test" could not find identity matching specified user-id: 28D6008F5CF39071 error: gpg failed to sign the data fatal: failed to write commit object

rushikeshadhav avatar Jun 19 '22 16:06 rushikeshadhav

I haven't got experience with signing commits, but probably @schalkneethling can help.

mikoMK avatar Jun 20 '22 11:06 mikoMK

I am getting this error after following all the steps of Verifying commit signatures Can anyone help me fix this? after running this $ git commit -S -m "test" could not find identity matching specified user-id: 28D6008F5CF39071 error: gpg failed to sign the data fatal: failed to write commit object

Sorry for the delay in getting back to you. I will get back to you as soon as possible.

schalkneethling avatar Jun 23 '22 11:06 schalkneethling