yari icon indicating copy to clipboard operation
yari copied to clipboard

chore(deps)!: migrate from yarn to npm + workspaces

Open caugner opened this issue 3 years ago • 18 comments

Experimental PR to see how easy a switch back to npm would go.

⚠️ This PR is blocked by [this error.](https://github.com/mdn/yari/pull/6322#issuecomment-1133227129): ``` Error: 17:56:38 Error: Cannot find module 'cookie' Require stack: - /home/runner/work/yari/yari/libs/get-locale/index.js - /home/runner/work/yari/yari/deployer/aws-lambda/content-origin-request/index.js - /home/runner/work/yari/yari/deployer/aws-lambda/tests/server.js ```

To update this PR:
  1. Run git rebase -i upstream/main
  2. Choose edit for the first two commits.
  3. Run git ls-files package-lock.json '**/package-lock.json' | xargs -n 1 dirname | xargs -n 1 -I % sh -c 'pushd %; rm -rf node_modules package-lock.json yarn.lock; npm install; popd'
  4. Run git commit --amend --date=now
  5. Run git rebase --continue

caugner avatar May 20 '22 07:05 caugner

This pull request has merge conflicts that must be resolved before we can merge this.

github-actions[bot] avatar May 20 '22 12:05 github-actions[bot]

I have no clue what causes this error:

Error:  17:56:38 Error: Cannot find module 'cookie'
Require stack:
- /home/runner/work/yari/yari/libs/get-locale/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/content-origin-request/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/tests/server.js
____STDERR____
Error: Cannot find module 'cookie'
Require stack:
- /home/runner/work/yari/yari/libs/get-locale/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/content-origin-request/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/tests/server.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/runner/work/yari/yari/libs/get-locale/index.js:1:19)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Object.nodeDevHook [as .js] (/home/runner/work/yari/yari/deployer/aws-lambda/tests/node_modules/node-dev/lib/hook.js:60:7)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)

(I even tried to add cookie everywhere, and it had no effect.)

caugner avatar May 20 '22 19:05 caugner

This pull request has merge conflicts that must be resolved before we can merge this.

github-actions[bot] avatar May 23 '22 11:05 github-actions[bot]

This pull request has merge conflicts that must be resolved before we can merge this.

github-actions[bot] avatar May 23 '22 23:05 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar May 31 '22 11:05 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Jun 01 '22 16:06 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Jun 02 '22 10:06 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Jun 03 '22 11:06 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Jun 03 '22 16:06 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Jun 06 '22 13:06 github-actions[bot]

I think install:all would help here.

caugner avatar Feb 09 '23 13:02 caugner

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 09 '23 18:02 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 10 '23 15:02 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 10 '23 15:02 github-actions[bot]

For the record, the last commit with passing checks was 8bd19186bc428bddcc83ef19ef89a60336972339.

caugner avatar Feb 10 '23 19:02 caugner

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 13 '23 12:02 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Apr 20 '23 12:04 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Oct 15 '24 20:10 github-actions[bot]