yari icon indicating copy to clipboard operation
yari copied to clipboard

Broken page layout when page not found

Open okjungsoo opened this issue 3 years ago • 2 comments

Summary

The page's layout is broken.

URL

https://developer.mozilla.org/en-US/docs/Web/API/ChromeWorker

Reproduction steps

  1. Go to https://developer.mozilla.org/en-US/docs/Web/API/ChromeWorker

Expected behavior

The page layout should look good.

Actual behavior

Broken layout

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Mac OS

Screenshot

Screen Shot 2022-03-30 at 2 33 07 PM

Anything else?

No response

Validations

okjungsoo avatar Mar 30 '22 05:03 okjungsoo

The layout of the page already looks better, but it's missing the header now:

image

caugner avatar Sep 14 '22 11:09 caugner

This will be fixed by https://github.com/mdn/yari/pull/7070.

PS: Here is the code location that returns the LoadingError without other elements like TopNavigation:

https://github.com/mdn/yari/blob/5c0fe01141754f17605929d63ef988489c1c43a8/client/src/document/index.tsx#L175-L177

caugner avatar Sep 14 '22 15:09 caugner