yari icon indicating copy to clipboard operation
yari copied to clipboard

fix(bcd): explain features with unknown earliest release version

Open gagan-bhullar-tech opened this issue 1 year ago • 7 comments

Summary

Fixes #11257

Problem

Explained in the linked issue

Solution

Renders the text

Yes Full support (earliest supporting release version unknown)


Screenshots

Before

image

After

image

How did you test this change?

gagan-bhullar-tech avatar Jul 24 '24 05:07 gagan-bhullar-tech

@gagan-bhullar-tech Could you please add before/after screenshots? 🙏

caugner avatar Jul 25 '24 09:07 caugner

@caugner

Before

image

After

image

gagan-bhullar-tech avatar Jul 25 '24 15:07 gagan-bhullar-tech

@danielhjacobs Could you please take another look? 🙏

caugner avatar Aug 09 '24 11:08 caugner

I'm not actually able to display some yari pages properly right now and I'm not sure why. The CSS and JS files are being served as HTML:

The stylesheet http://localhost:3000/static/css/main.debc7a6f.css was not loaded because its MIME type, “text/html”, is not “text/css”. Uncaught SyntaxError: expected expression, got '<'

Screenshot from 2024-08-09 10-32-08

danielhjacobs avatar Aug 09 '24 14:08 danielhjacobs

Also worth noting, @queengooborg is making a concerted effort to remove all instances of true from the BCD, so this PR will only be useful for probably less than a month before that effort is finished.

There are 30 remaining files, all either webextensions.api or webextensions.manifest: https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data+%22%5C%22version_added%5C%22%3A+true%22&type=code (most were actually just updated, but some true values seem to have been missed).

danielhjacobs avatar Aug 09 '24 14:08 danielhjacobs

Ah I see:

#4654

Unfortunately, many of the pages that reproduce this issue are there.

danielhjacobs avatar Aug 09 '24 14:08 danielhjacobs

For reference, no files are left that are affected by this PR.

danielhjacobs avatar Aug 27 '24 18:08 danielhjacobs

This PR is no longer be necessary, and https://github.com/mdn/yari/issues/11257 has been fixed by BCD updates. See https://github.com/openwebdocs/project/issues/206 and https://github.com/mdn/browser-compat-data/pull/24174.

danielhjacobs avatar Nov 27 '24 21:11 danielhjacobs

As @danielhjacobs wrote, there are no occurrences of "Yes" left, so I'm closing this PR.

@gagan-bhullar-tech Thank you for taking the time to implement this change, and sorry we didn't get to land it. We appreciate your contribution!

caugner avatar Jan 02 '25 18:01 caugner