todo-react
todo-react copied to clipboard
feat: change heading based on filter
Description
Change the heading text so that it reflects the current tab. Previously, all tabs said "remaining", now they say:
- All: "N tasks"
- Active: "N tasks remaining" (same as before)
- Completed: "N tasks completed"
Motivation
I started using this and was confused that when I went to my completed tasks, it said those tasks were still "remaining". All the tab filters say "remaining" but I think of "remaining" tasks as the tasks still left to do, not the completed ones. Now the header text appropriately reflects the active filter.
Additional details
None
Related issues and pull requests
None
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.
I'm going to close this due to inactivity, if you'd like to come back to this, please reply or reopen it! Thanks :)