stumptown-content icon indicating copy to clipboard operation
stumptown-content copied to clipboard

Node version minimum?

Open peterbe opened this issue 4 years ago • 4 comments

We're currently using node_js: stable which means, as of today, version v12.10.0.

Should we stick to Node v10 to make sure we're not using features of Node that not everyone might have? I'd hate it if someone is using an OS that makes it really hard to upgrade to v12 and now they can't contribute. Hopefully, we're not using any "bleedy edge" features. I also don't know what the difference is between v10 and v12 or how inconvenient it might be to get version 12 installed.

peterbe avatar Sep 19 '19 20:09 peterbe

I don't know how to specify this in the Travis CI config, but I like the idea of supporting the current active LTS release or newer. Seems like a good balance between getting recent features and the likelihood that contributors will have access to a supported version.

ddbeck avatar Sep 25 '19 14:09 ddbeck

I think you just put node_js: 10. For example However, it's my personal goal to move this repo (at least to try) to GitHub Actions so we can worry about it then.

peterbe avatar Sep 25 '19 14:09 peterbe

Now, node_js: stable means v13.1.0 in TravisCI. What I'd rather go for is to say that our minimum is "Stable" as Nodejs.org defines it. Or perhaps the language is to say "The latest LTS release" . I.e. not saying a specific number but just keep up with what LTS is.

So that means scripts would be able to use Node v12 features (hi String.prototype.matchAll!) and we should change TravisCI to use that instead.

peterbe avatar Nov 19 '19 17:11 peterbe

Having played with GitHub Actions for BCD a little bit, an idea: an Action that checks https://github.com/nodejs/Release/blob/master/schedule.json for the most recent actively maintained LTS release. You could use it to change the travis CI config or use it a variable for the next build step. (There are some annoyances with node_modules in Actions though, so it might be worth setting up a separate repo for it.)

ddbeck avatar Nov 19 '19 17:11 ddbeck