T - Link subscription banner to subscription banner page

[peterbe]

Summary At the moment, even though not enabled from waffle, the subscription banner looks like this:

Instead, it needs to look like this:

(does this url work?)

And that link of the button needs to go to /$locale/payments/ (note the trailing slash which is necessary for the subscription management page URL to work)

This also means that the subscription banner no longer needs to require that the user is logged in. Only that the waffle flag says it's ok to display.

[schalkneethling]

This also means that the subscription banner no longer needs to require that the user is logged in. Only that the waffle flag says it's ok to display.

I am still not 100% on this part. Unless things have changed that I am not aware of, I am pretty sure this should still be limited to logged-in users only based on the phased roll-out:

1. Staff on edit profile
2. Staff via the banner(points to /payments/) on all pages
3. Logged in user via the banner(points to /payments/) on all pages (percentage limited via waffle flag)
4. All users via the banner(points to /payments/) (percentage limited via waffle flag)

@atopal Thoughts?

[peterbe]

Those are all issued embedded inside the Waffle and they're in Kadir's domain. The /$locale/payments/ page isn't forbidden for anonymous users so it'd be possible and safe to link anonymous users there.

What I'm arguing is that the banner code should need to double-check things when it would be possible to have just 1 source of truth (the waffle flag).

[atopal]

@schalkneethling I'm not sure what the question for me is? We have issue #6557 in the sprint. So the banner should be shown to non-logged in users when that story is implemented, but: it should still be behind a waffle flag, because we will not show the banner to anyone before we are actually ready to launch