kuma icon indicating copy to clipboard operation
kuma copied to clipboard

T - Cache Subscription Info: CC Info and Customer Count

Open tobinmori opened this issue 4 years ago • 5 comments

  • locally 1.5s w/o subscription
  • 2.5s w/subscription

tobinmori avatar Mar 10 '20 13:03 tobinmori

@tobinmori what is this connected to? storing cc info sounds like something we should talk about.

atopal avatar Mar 10 '20 15:03 atopal

None of it is highly sensitive data (you could not charge based off of it), but yes, it's a fair point.

tobinmori avatar Mar 27 '20 19:03 tobinmori

What is the point of this? Where are we using it or intend to use it?

peterbe avatar Mar 27 '20 19:03 peterbe

I think @Gregoor had mentioned that the acct settings page was slow due to the StripeAPI call to get payment info.

We can not pre-optimize unless this seems like a real problem. So not high priority.

tobinmori avatar Mar 27 '20 19:03 tobinmori

There was https://github.com/mdn/kuma/issues/6665 which was about the Edit Profile page which isn't an important page. It'd be a much better idea to move subscription info into the read-only site. Then you can load the SPA from the server and once it's loaded, an XHR request queries the backend for the subscription info and that'll be a pretty decent experience. Much similar to the mugshot/sign in thingy in the nav header.

peterbe avatar Mar 27 '20 19:03 peterbe