kuma Tidy up contribution amount and support email

Screen Shot 2020-03-06 at 11 58 13 AM

So there are at least 3 open PRs (at the time of writing) that hardcodes the $5 in jinja templates and JS code. But also noticed we have settings.CONTRIBUTION_SUPPORT_EMAIL but if you grep for mdn-support it appears in two templates and one .jsx file.

If you know you PR is part of this, please mention it so we can set up blocking relationships.

Mar 06 '20 17:03 peterbe

https://github.com/mdn/kuma/pull/6633

Mar 09 '20 16:03 schalkneethling

@schalkneethling I think your subscription banner closed this by accident. I don't understand how. THere's no mention of this issue in the commit message: https://github.com/mdn/kuma/commit/639a3cae91c4119fca3ece9df64b5ecb21e59889

Any idea?

Mar 16 '20 14:03 peterbe

@schalkneethling I think your subscription banner closed this by accident. I don't understand how. THere's no mention of this issue in the commit message: 639a3ca

Any idea?

Could it somehow be because of this https://github.com/mdn/kuma/issues/6654#issuecomment-596630990

Mar 16 '20 20:03 schalkneethling

Aha! I think the comment referenced above might have caused this to happen(see the right-hand sidebar)

Screenshot 2020-03-16 at 22 02 50

Mar 16 '20 20:03 schalkneethling

That's a ZenHub thing, no? Bad ZenHub!

Mar 17 '20 11:03 peterbe

One thing to watch out for is that we have people who set up subscriptions BEFORE we launched this version 2 of money intakes. If we hardcode the number too much and one of these people return we might be lying.

Mar 18 '20 19:03 peterbe

Note what @Gregoor did when was in there changing how the Subscription banner worked: https://github.com/mdn/kuma/commit/3bd820bb04e0f113ae06073b3e4d0b80b5e65e59#diff-31dcf5c77bbb5f6109cb1de27238ed0cR229 We might want to take this as a cue for all other uses of the $5 amount in any of the JS files.

Apr 17 '20 14:04 peterbe