interactive-examples icon indicating copy to clipboard operation
interactive-examples copied to clipboard

Improve contrast of interactive example

Open schalkneethling opened this issue 3 years ago • 6 comments
trafficstars

There are probably other situations where too little contrast makes things hard to see. Compare these white letters on bright yellow background atop this page,

https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap

I'll stop reporting these, anyone could find them easily.

Originally posted by @iDave2 in https://github.com/mdn/yari/issues/5387#issuecomment-1055782535

schalkneethling avatar Mar 21 '22 17:03 schalkneethling

Uploading r4{bfc025b} (290f7d3c-25a8-48b2-b308-0d7245079b1a id=0x7f0a0400 tag=BaseCommentFragment) …

@schalkneethling Are you referring to this part. If so I need to change the BG color for better visibility right?

vedant-z avatar Nov 29 '22 16:11 vedant-z

Has this already been fixed in the following PR?

  • [x] https://github.com/mdn/css-examples/pull/75

bsmth avatar Nov 29 '22 17:11 bsmth

Unfortunately there are still plenty of examples with too low contrast.

NiedziolkaMichal avatar Nov 29 '22 18:11 NiedziolkaMichal

@NiedziolkaMichal Can you point out me some so that I can get started contributing to this repository

vedant-z avatar Nov 29 '22 20:11 vedant-z

Those are all CSS examples that don't meet proper contrast guidelines in dark theme according to the firefox accessibility tool:

NiedziolkaMichal avatar Nov 29 '22 21:11 NiedziolkaMichal

This has again been reported at https://github.com/mdn/interactive-examples/issues/2368. It's sad that such a bad usability issue has been open for so long :(

See also https://github.com/mdn/bob/issues/859.

wbamberg avatar Dec 17 '22 19:12 wbamberg