data icon indicating copy to clipboard operation
data copied to clipboard

Add text keyword to background-clip

Open TrySound opened this issue 1 year ago • 2 comments

Description

Added text keyword to background-clip value.

Motivation

All browsers already support unprefixed background-clip with text keyword.

Additional details

  • https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip

Related issues and pull requests

  • https://github.com/mdn/data/pull/201

TrySound avatar Jun 28 '24 14:06 TrySound

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

github-actions[bot] avatar Jun 28 '24 14:06 github-actions[bot]

Thanks for the additions. The page https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip#specifications is currently targeting spec version "Module Level 3", and the syntax for background-clip: text may change, there are open discussions about it: https://drafts.csswg.org/css-backgrounds-4/#propdef-background-clip.

We may want to wait until the open questions on this spec are resolved. The linked PR (#201) has a discussion about this already.

bsmth avatar Sep 17 '24 08:09 bsmth

Wow, nice!

TrySound avatar Nov 05 '24 18:11 TrySound

also per bcd, border-area value is supported in safari preview browser, this can be added at the same time

see: https://bugs.webkit.org/show_bug.cgi?id=277693 https://bugs.webkit.org/show_bug.cgi?id=277842 https://bugs.webkit.org/show_bug.cgi?id=277910

skyclouds2001 avatar Nov 30 '24 08:11 skyclouds2001

I think this has now been fixed in the linked PR, right?

bsmth avatar Jan 03 '25 12:01 bsmth

yes, see https://github.com/mdn/data/blob/main/css/properties.json#L2242-L2262 and https://github.com/mdn/data/blob/main/css/syntaxes.json#L83-L85

skyclouds2001 avatar Jan 03 '25 14:01 skyclouds2001

Thanks @skyclouds2001 - @TrySound , I'm sorry your PR didn't land, but this has been resolved, so I'm going to close it. Thanks a lot, and I hope you contribute again :)

bsmth avatar Jan 03 '25 15:01 bsmth