content icon indicating copy to clipboard operation
content copied to clipboard

Add support for message fragmentation to handle large messages

Open Ashish-CodeJourney opened this issue 1 year ago • 11 comments

Description

Implemented message fragmentation to support the transmission of large messages by splitting them into smaller chunks. This enhancement ensures compatibility with systems that have strict size limits on individual messages, improving the overall reliability of the messaging system.

Motivation

The primary motivation behind these changes is to address the limitation where messages exceeding a predefined size limit could not be transmitted due to size restrictions on the receiving end. By introducing message fragmentation, we enable the successful transmission of all messages, regardless of their size, thereby enhancing the robustness and flexibility of our messaging system.

Additional details

This implementation is based on the understanding that many applications and services impose strict size constraints on incoming messages. By allowing messages to be split into smaller chunks and then reassembled on the receiving end, we ensure broader compatibility and improved performance in scenarios involving large data transfers.

Related issues and pull requests

Fixes #34151

Ashish-CodeJourney avatar Jun 14 '24 09:06 Ashish-CodeJourney

Preview URLs

(comment last updated: 2024-07-13 12:12:20)

github-actions[bot] avatar Jun 14 '24 09:06 github-actions[bot]

it looks like @jpmedley is not active from a long time @Josh-Cena can you please look into this PR and my other PRs where he is assigned as a reviewer ?

Ashish-CodeJourney avatar Jun 19 '24 08:06 Ashish-CodeJourney

This is very related to https://github.com/mdn/content/pull/29104 where @rebloor seems to hit a similar error as https://github.com/mdn/content/issues/34151. I'm going to add them as a reviewer.

Josh-Cena avatar Jun 19 '24 09:06 Josh-Cena

This is very related to #29104 where @rebloor seems to hit a similar error as #34151. I'm going to add them as a reviewer.

Thanks

Ashish-CodeJourney avatar Jun 19 '24 10:06 Ashish-CodeJourney

@rebloor does this sounds fine ?

Ashish-CodeJourney avatar Jun 20 '24 11:06 Ashish-CodeJourney

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

rebloor avatar Jun 21 '24 19:06 rebloor

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

Okay, let's wait for his review

Ashish-CodeJourney avatar Jun 24 '24 04:06 Ashish-CodeJourney

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

Okay, let's wait for his review

@

@Ashish-CodeJourney added @dotproto to review the code. Otherwise, I'll need to spin up some code and test.

Okay, let's wait for his review

@rebloor @dotproto any updates ?

Ashish-CodeJourney avatar Jul 13 '24 12:07 Ashish-CodeJourney

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

dotproto avatar Jul 17 '24 20:07 dotproto

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

Makes sense. let me know if you need me to update anything in this

Ashish-CodeJourney avatar Jul 17 '24 20:07 Ashish-CodeJourney

I'm trying to clear out my PR backlog today. I just gave this PR a read through and my current thinking is that if we do add chunking to the examples, we should probably do so to both the Python 3 and Node.js code at roughly the same time. I'm tentatively thinking about merging this and another similar PR for Node into a temp branch, cleaning up the text a little, and then landing that temp branch in main.

Makes sense. let me know if you need me to update anything in this

@rebloor @dotproto @Josh-Cena it's open since 4 - 5 months any updates ?

Ashish-CodeJourney avatar Oct 09 '24 05:10 Ashish-CodeJourney