content
content copied to clipboard
mdn
Add initial content for setHTMLUnsafe and parseHTMLUnsafe
Description
Adds basic pages for setHTMLUnsafe and parseHTMLUnsafe.
Motivation
These functions are recently shipping across the board and there's no indication of their existence on MDN.
Additional details
Related issues and pull requests
Relates to https://github.com/mdn/content/issues/32731
Preview URLs (7 pages)
Flaws (10)
Note! 4 documents with no flaws that don't need to be listed. 🎉
URL: /en-US/docs/Web/API/ShadowRoot
Title: ShadowRoot
Flaw count: 3
- macros:
/en-US/docs/Web/API/ShadowRoot/getSelection does not exist/en-US/docs/Web/API/ShadowRoot/elementFromPoint does not exist/en-US/docs/Web/API/ShadowRoot/elementsFromPoint does not exist
URL: /en-US/docs/Web/API/Element
Title: Element
Flaw count: 1
- macros:
/en-US/docs/Web/API/Element/getBoxQuads does not exist
URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 6
- macros:
/en-US/docs/Web/API/Document/xmlStandalone does not exist/en-US/docs/Web/API/Document/captureEvents does not exist/en-US/docs/Web/API/Document/getBoxQuads does not exist/en-US/docs/Web/API/Document/releaseEvents does not exist/en-US/docs/Web/API/Document/queryCommandIndeterm does not exist- and 1 more flaws omitted
(comment last updated: 2024-05-24 00:03:38)
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lukewarlow I think this is just a little too minimal. We need to at least explain why these exist and properly cross link. Live examples are optional (I love them).
FYI MDN has a PR acceptance rule that essentially says new stuff has to be of a pretty high standard, whereas, if you are updating existing stuff the bar is "an improvement". I don't think there is a lot of work here if the reason for these to exist is known.
@lukewarlow I think you may have run out of time to do this on that day :-). I might have a go at this on Monday or Tuesday if you don't - now mfreed has answered our questions it's a lot more clear how this works. Note that I'm doing cross linking to some of these methods in #33600
@lukewarlow I've updated this to reflect the comments. Can you and @Elchi3 sanity check/review this?
Note, I am likely to add some live examples for the methods on Friday, but might do that on a new PR.
LGTM other than that suggestion. Apologies I didn't find time to get back to this.
LGTM other than that suggestion. Apologies I didn't find time to get back to this.
@lukewarlow I merged your suggestions. Thanks for the review. No need to apologize - really appreciate you kicking this off. If you can though, it is often good to add a short note that you have run out of time and you're happy for other people to take it forward (assuming you are).