content icon indicating copy to clipboard operation
content copied to clipboard

Created paint-order example in HTML

Open srikanth-kandi opened this issue 1 year ago • 5 comments
trafficstars

Description

Changed the SVG example for paint-order to HTML example using <div> tags and modified the CSS attributes stroke and stroke-width to -webkit-text-stroke-color and -webkit-text-stroke-width.

Related issues and pull requests

Fixes #32236

https://github.com/mdn/content/assets/87417638/1295abe5-b119-4c7e-a25c-5f16940c8830

srikanth-kandi avatar Feb 13 '24 12:02 srikanth-kandi

Preview URLs

(comment last updated: 2024-02-20 17:10:33)

github-actions[bot] avatar Feb 13 '24 12:02 github-actions[bot]

It would be great if we cover both cases for HTML & SVG instead of replacing SVG entirely. Do you want to add your example as an addition so we have two - one for HTML and one for SVG?

But what might be the order of the examples, SVG first HTML second or vice versa?

srikanth-kandi avatar Feb 15 '24 03:02 srikanth-kandi

It would be great if we cover both cases for HTML & SVG instead of replacing SVG entirely. Do you want to add your example as an addition so we have two - one for HTML and one for SVG?

For now, I placed SVG first and HTML example second here is the expected output below

https://github.com/mdn/content/assets/87417638/db1159b0-89ec-4956-85a2-06dd651cc63e

srikanth-kandi avatar Feb 15 '24 04:02 srikanth-kandi

For now, I placed SVG first and HTML example second here is the expected output below

This looks great to me, thanks.

bsmth avatar Feb 15 '24 13:02 bsmth

hey @bsmth, could you merge this pull request :)

srikanth-kandi avatar Feb 17 '24 17:02 srikanth-kandi

hey @bsmth, could you merge this pull request :)

Thanks for the reminder, merging now!

bsmth avatar Feb 22 '24 12:02 bsmth