content icon indicating copy to clipboard operation
content copied to clipboard

Published 20 hours ago • verified publisher icon mdn

Remove moz api

Open qibing147147 opened this issue 3 years ago • 11 comments

Description

Remove mentions of moz APIs from drag&drop documentation

fix issue [Remove mentions of moz APIs from drag&drop documentation](#21878 )

Related issues and pull requests

Fixes https://github.com/mdn/content/issues/21878

qibing147147 avatar Nov 06 '22 02:11 qibing147147

Preview URLs (23 pages)
Flaws (8)

Note! 21 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/DataTransfer Title: DataTransfer Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/Guide/User_input_methods Title: User input and controls Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/Screen/orientationchange does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/HTML/Editable_content
    • Can't resolve /en-US/docs/Web/API/Document/dragstart_event
    • Can't resolve /en-US/docs/Web/Guide/HTML/Editable_content
    • Can't resolve /en-US/docs/Web/Guide/HTML/Editable_content
    • Can't resolve /en-US/Firefox_OS/Platform/Keyboard_events_in_Firefox_OS_TV
    • and 1 more flaws omitted
External URLs (33)

URL: /en-US/docs/Web/API/DataTransferItem/kind Title: DataTransferItem.kind

URL: /en-US/docs/Web/API/HTML_Drag_and_Drop_API Title: HTML Drag and Drop API

URL: /en-US/docs/Web/API/HTML_Drag_and_Drop_API/Drag_operations Title: Drag operations

URL: /en-US/docs/Web/API/HTML_Drag_and_Drop_API/Recommended_drag_types Title: Recommended Drag Types

URL: /en-US/docs/Web/API/DragEvent Title: DragEvent

URL: /en-US/docs/Web/API/DataTransfer Title: DataTransfer

URL: /en-US/docs/Web/API/DataTransfer/types Title: DataTransfer.types

URL: /en-US/docs/Web/API/DataTransfer/mozGetDataAt Title: DataTransfer.mozGetDataAt()

URL: /en-US/docs/Web/API/DataTransfer/mozCursor Title: DataTransfer.mozCursor

URL: /en-US/docs/Web/API/DataTransfer/mozUserCancelled Title: DataTransfer.mozUserCancelled

URL: /en-US/docs/Web/API/DataTransfer/effectAllowed Title: DataTransfer.effectAllowed

URL: /en-US/docs/Web/API/DataTransfer/mozClearDataAt Title: DataTransfer.mozClearDataAt()

URL: /en-US/docs/Web/API/DataTransfer/dropEffect Title: DataTransfer.dropEffect

URL: /en-US/docs/Web/API/DataTransfer/mozSourceNode Title: DataTransfer.mozSourceNode

URL: /en-US/docs/Web/API/DataTransfer/mozTypesAt Title: DataTransfer.mozTypesAt()

URL: /en-US/docs/Web/API/DataTransfer/items Title: DataTransfer.items

URL: /en-US/docs/Web/API/DataTransfer/clearData Title: DataTransfer.clearData()

URL: /en-US/docs/Web/API/DataTransfer/setDragImage Title: DataTransfer.setDragImage()

URL: /en-US/docs/Web/API/DataTransfer/setData Title: DataTransfer.setData()

URL: /en-US/docs/Web/API/DataTransfer/getData Title: DataTransfer.getData()

URL: /en-US/docs/Web/API/DataTransfer/mozItemCount Title: DataTransfer.mozItemCount

URL: /en-US/docs/Web/API/DataTransfer/addElement Title: DataTransfer.addElement()

URL: /en-US/docs/Web/Guide/User_input_methods Title: User input and controls

(this comment was updated 2022-11-09 03:17:41.704874)

github-actions[bot] avatar Nov 07 '22 04:11 github-actions[bot]

This is really nice work but I think what #21878 is requesting is not just the removal of files/en-us/web/api/datatransfer/mozsetdataat, but also the removal of all the following:

files/en-us/web/api/datatransfer/mozcleardataat/
files/en-us/web/api/datatransfer/mozcursor/
files/en-us/web/api/datatransfer/mozgetdataat/
files/en-us/web/api/datatransfer/mozitemcount/
files/en-us/web/api/datatransfer/mozsourcenode/
files/en-us/web/api/datatransfer/moztypesat/
files/en-us/web/api/datatransfer/mozusercancelled/

@evilpie, can you confirm?

These apis may be used in old Firefox,so i just remove quote in main docs,but retain the api entry

qibing147147 avatar Nov 07 '22 09:11 qibing147147

I think we could remove the API docs for mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt, because those are definitely unusable now. mozCursor, mozUserCacelled and mozSourceNode stil seem to exist.

evilpie avatar Nov 07 '22 09:11 evilpie

I think we could remove the API docs for mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt, because those are definitely unusable now. mozCursor, mozUserCacelled and mozSourceNode stil seem to exist.

Remove mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt completely? ut if someone still wants to use these apis on the old browser,they may not be able to see these apis

qibing147147 avatar Nov 07 '22 09:11 qibing147147

@qibing147147

Remove mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt completely? ut if someone still wants to use these apis on the old browser,they may not be able to see these apis

But the current patch in this PR is already completely removing the entire mozSetDataAt article, right?

How are the cases of mozItemCount, mozClearDataAt, and mozGetDataAt different than the case of mozSetDataAt?

sideshowbarker avatar Nov 09 '22 03:11 sideshowbarker

@qibing147147

Remove mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt completely? ut if someone still wants to use these apis on the old browser,they may not be able to see these apis

But the current patch in this PR is already completely removing the entire mozSetDataAt article, right?

How are the cases of mozItemCount, mozClearDataAt, and mozGetDataAt different than the case of mozSetDataAt?

@qibing147147

Remove mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt completely? ut if someone still wants to use these apis on the old browser,they may not be able to see these apis

But the current patch in this PR is already completely removing the entire mozSetDataAt article, right?

How are the cases of mozItemCount, mozClearDataAt, and mozGetDataAt different than the case of mozSetDataAt?

Sorry,I remove the mozSetDataAt article by mistake,I will revert the mozSetDataAt article. At the same time, I will remove quotes of mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt in main docs,but retain the entrance of these apis.Is that OK, you think?

qibing147147 avatar Nov 09 '22 07:11 qibing147147

Is that OK, you think?

I think @evilpie should be the one to decide what’s OK here — since he’s the one who raised the issue this PR is intended to resolve. But at https://github.com/mdn/content/pull/22092#issuecomment-1305357940, he already said:

I think we could remove the API docs for mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt, because those are definitely unusable now.

…so I imagine we can assume he’s not OK with not removing them.

This PR overall is otherwise great, and I’d be happy to merge it as-is. But merging it as-is wouldn’t resolve https://github.com/mdn/content/issues/21878 — so if we do merge it as-is, then pretty much the next thing I’d do is to then open a follow-up PR myself that removes the mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt docs.

sideshowbarker avatar Nov 09 '22 08:11 sideshowbarker

Is that OK, you think?

I think @evilpie should be the one to decide what’s OK here — since he’s the one who raised the issue this PR is intended to resolve. But at #22092 (comment), he already said:

I think we could remove the API docs for mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt, because those are definitely unusable now.

…so I imagine we can assume he’s not OK with not removing them.

This PR overall is otherwise great, and I’d be happy to merge it as-is. But merging it as-is wouldn’t resolve #21878 — so if we do merge it as-is, then pretty much the next thing I’d do is to then open a follow-up PR myself that removes the mozItemCount, mozClearDataAt, mozGetDataAt and mozSetDataAt docs.

It's OK. I will remove quotes and entrance of these apis.

I'd like to ask u a question.

Why is the Markdownlint executed incorrectly?

image

qibing147147 avatar Nov 09 '22 08:11 qibing147147

I'd like to ask u a question.

Why is the Markdownlint executed incorrectly?

I don’t know. We’ve been having a variety of git-related failures with the Markdown linter running under our GitHub Actions CI. I think it has something to do with the specific GH action that does the checkout only doing a shallow clone rather than fully cloning the repo. But I’m not sure. Regardless, the error message shown in https://github.com/mdn/content/pull/22092#issuecomment-1308416230 doesn’t indicate any specific problem with the changes in this PR but is instead some unrelated failure in our tooling — and so, we could merge this PR in spite of that.

sideshowbarker avatar Nov 09 '22 09:11 sideshowbarker

I'd like to ask u a question. Why is the Markdownlint executed incorrectly?

I don’t know. We’ve been having a variety of git-related failures with the Markdown linter running under our GitHub Actions CI. I think it has something to do with the specific GH action that does the checkout only doing a shallow clone rather than fully cloning the repo. But I’m not sure. Regardless, the error message shown in #22092 (comment) doesn’t indicate any specific problem with the changes in this PR but is instead some unrelated failure in our tooling — and so, we could merge this PR in spite of that.

I'd like to ask u a question. Why is the Markdownlint executed incorrectly?

I don’t know. We’ve been having a variety of git-related failures with the Markdown linter running under our GitHub Actions CI. I think it has something to do with the specific GH action that does the checkout only doing a shallow clone rather than fully cloning the repo. But I’m not sure. Regardless, the error message shown in #22092 (comment) doesn’t indicate any specific problem with the changes in this PR but is instead some unrelated failure in our tooling — and so, we could merge this PR in spite of that.

OK.Thanks for ur reply

qibing147147 avatar Nov 09 '22 09:11 qibing147147

I'd like to ask u a question. Why is the Markdownlint executed incorrectly?

I don’t know. We’ve been having a variety of git-related failures with the Markdown linter running under our GitHub Actions CI. I think it has something to do with the specific GH action that does the checkout only doing a shallow clone rather than fully cloning the repo. But I’m not sure. Regardless, the error message shown in #22092 (comment) doesn’t indicate any specific problem with the changes in this PR but is instead some unrelated failure in our tooling — and so, we could merge this PR in spite of that.

I have remove moz apis completely,would you mind heping me review again?

qibing147147 avatar Nov 09 '22 14:11 qibing147147

@qibing147147, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

sideshowbarker avatar Nov 10 '22 06:11 sideshowbarker