mdn
chore: Opt-in cleaned folders and CI for Prettier
These were removed from the Huskier PR, so resubmitting to review separately
After this or with this one, we could add the prettier call to the Auto PR fix job
We want to discuss the plan to move forward with Prettier once everybody returns from the all-hand Mozilla trip (for some), and holidays (for others).
Meanwhile, we can fix content to match the output of Prettier, getting experience with the limitations of the tool (weirdness with inline elements, CDATA and MathML code "minimization", a few oddities with CSS, …), but we shouldn't move forward with automation before the plan has been discussed on mdn/mdn-community/discussions and agreed.
LGTM, but the only problem I see is that those "already fixed" files don't get auto-fixed via lint-staged yet, so the failing test may be a surprise for contributors.
When these folders are opted back in, lint-stage/husky will autofix any regressions going forward
Gave this a rebase, and updated the globs for the global job and scripts to run for prettier changes. Still green with the now opted in folders
This pull request has merge conflicts that must be resolved before it can be merged.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has merge conflicts that must be resolved before it can be merged.
@queengooborg @bsmth noticed that #24046 landed. Maybe you're ready to look at this now
Preview URLs (6 pages)
Flaws (1)
Note! 5 documents with no flaws that don't need to be listed. 🎉
URL: /en-US/docs/Web/CSS/CSS_Scroll_Snap/Basic_concepts
Title: Basic concepts of CSS Scroll Snap
Flaw count: 1
- broken_links:
Can't resolve /en-US/docs/Web/CSS/CSS_Scroll_Snap/
(comment last updated: 2023-05-19 23:33:30)
This pull request has merge conflicts that must be resolved before it can be merged.
This pull request has merge conflicts that must be resolved before it can be merged.
@teoli2003 let me know when to rebase this, as I'm picking up conflicts with all the PRs your landing right now
This pull request has merge conflicts that must be resolved before it can be merged.
This pull request has merge conflicts that must be resolved before it can be merged.
@queengooborg @teoli2003 @bsmth note the failure from a previously cleaned up folder. We need this CI backing or things will continue to creep back in.
This pull request has merge conflicts that must be resolved before it can be merged.
There are some additional changes included in this PR that aren't entirely about just opting into using Prettier to scan the files, such as adding the slashes into the
.prettierignore, sorting entries in other workflows and renaming jobs.
I've minimized the diff on the other job to just add the trigger on .prettier* changes. For the slash discussion, i've "unresolved the previous discussion about that one so it's visible again
Additionally, I think that we can combine the Markdownlint and Prettier command runs into a single workflow job.
I added your suggestion, then I realized there was a bug from when I had changed from the old "diff files" action to the current one, so I rebased, but kept the collasped single job
I've minimized the diff on the other job to just add the trigger on .prettier* changes.
Thank you, much appreciated!
For the slash discussion, i've "unresolved the previous discussion about that one so it's visible again
Sounds good! I opened up #24338 to add them into our config; just waiting on review for it!
added your suggestion, then I realized there was a bug from when I had changed from the old "diff files" action to the current one, so I rebased, but kept the collasped single job
👍
@queengooborg I cherry-picked your ignore changes from https://github.com/mdn/content/pull/24338 and fixed an issue on one of the ignores. I fixed the single unrelated failing file, but it would get fixed by the auto-PR job after this anyway
This pull request has merge conflicts that must be resolved before it can be merged.
This pull request has merge conflicts that must be resolved before it can be merged.