content icon indicating copy to clipboard operation
content copied to clipboard

fix: Glossary call format

Open nschonni opened this issue 3 years ago • 3 comments

  • Remove duplicate name calls as separate paramater
  • Removed 3rd parameter calls that Glossary doesn't have in Yari

nschonni avatar Sep 12 '22 06:09 nschonni

Preview URLs (15 pages)
Flaws (11)

Note! 13 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/43 Title: Firefox 43 for developers Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/PerformanceRenderTiming does not exist
    • /en-US/docs/Web/API/PerformanceCompositeTiming does not exist
    • /en-US/docs/Web/API/Screen/mozOrientation does not exist
    • /en-US/docs/Web/API/Screen/onmozorientationchange does not exist
    • /en-US/docs/Web/API/Screen/mozLockOrientation does not exist
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline_API

URL: /en-US/docs/Glossary/AJAX Title: Ajax Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/XMLHttpRequest redirects to /en-US/docs/Glossary/XHR_(XMLHttpRequest)
    • /en-US/docs/Glossary/XMLHttpRequest redirects to /en-US/docs/Glossary/XHR_(XMLHttpRequest)

(this comment was updated 2022-09-27 23:59:45.668922)

github-actions[bot] avatar Sep 12 '22 06:09 github-actions[bot]

@nschonni , is there a reason this is draft, or can we merge it?

wbamberg avatar Sep 21 '22 01:09 wbamberg

The XHR_(XMLHttpRequest) one is pending another PR that renames that doc, but I could just rollback that part to let the rest land

nschonni avatar Sep 21 '22 01:09 nschonni

@nschonni I know you were waiting for another PR to be merged. Just wanted to bump this as it has been a month.... not sure if the blocker is resolved.

estelle avatar Nov 01 '22 23:11 estelle

Sorry, I updated my comment above to link to the actual other stalled PR. This one has one rename for the XHR_(XMLHttpRequest). I can rebase that bit out if you want to get this landed

nschonni avatar Nov 02 '22 00:11 nschonni

For the XHR_(XMLHttpRequest), I can rebase that bit out if you want to get this landed

Let's do this @nschonni, there are clear improvements here that would be great to get in!

bsmth avatar Nov 02 '22 13:11 bsmth

Realized that since there is an old redirect for XMLHttpRequest this will still work, the flaw is just complaining about the redirect, rather than fully failing. Marked as ready

nschonni avatar Nov 02 '22 19:11 nschonni

Thanks @nschonni, merging 👍🏻

bsmth avatar Nov 03 '22 09:11 bsmth