content icon indicating copy to clipboard operation
content copied to clipboard

How to set private window permission?

Open szmarczak opened this issue 2 years ago • 2 comments

MDN URL

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings

What specific section or headline is this issue about?

Note

What information was incorrect, unhelpful, or incomplete?

Note: The ability to change proxy settings requires private window access because proxy settings affect both private and non-private windows. Therefore, if an extension has not been granted private window permission, calls to proxy.settings.set() will throw an exception.

The information is not complete. It's missing how to set the private window permission.

What did you expect to see?

It should contain information how to set the permission.

Searchfox: https://searchfox.org/mozilla-central/rev/108c7843696fdf951083889d6fb858953139be96/toolkit/components/extensions/parent/ext-proxy.js#217

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

I looked at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions but failed to find "private window".

MDN metadata

Page report details
  • Folder: en-us/mozilla/add-ons/webextensions/api/proxy/settings
  • MDN URL: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings
  • GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/mozilla/add-ons/webextensions/api/proxy/settings/index.md
  • Last commit: https://github.com/mdn/content/commit/c87ca062c8d120223f4919b8c45441eec26e9e59
  • Document last modified: 2022-07-06T10:18:57.000Z

szmarczak avatar Jul 19 '22 19:07 szmarczak

I just noticed this in about:addons

image

Having browser.proxy affect both contexts extremely degrades DX.

szmarczak avatar Jul 19 '22 20:07 szmarczak

@szmarczak while we do need to clarify the issue you've identified, I wanted to let you know that we have recently added a clarification to the incognito manifest key to explain that permission for an extension to access private windows is under user control.

rebloor avatar Aug 03 '22 17:08 rebloor

Thank you @rebloor, greatly appreciated! ❤️

szmarczak avatar Sep 07 '22 19:09 szmarczak