content icon indicating copy to clipboard operation
content copied to clipboard

Fix error message explanation about var

Open teoli2003 opened this issue 3 years ago • 5 comments

Fixes #18265

teoli2003 avatar Jul 12 '22 10:07 teoli2003

Preview URLs

(comment last updated: 2023-03-29 19:59:34)

github-actions[bot] avatar Jul 12 '22 10:07 github-actions[bot]

image

The const one is an entirely different page (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Missing_initializer_in_const) and should be removed from this page (it was an oversight during the var -> const conversion); the let one still points to the current page so I think we can keep it—although the current error message in both Chrome and Firefox is pretty useless.

Josh-Cena avatar Jul 22 '22 05:07 Josh-Cena

Oh yes, you are right.

I think this error can't happen anymore. Nevertheless, I'm worried that the issue reporter said there are still links to this page from inside Firefox dev tools. I wonder if we should create a new page, for the new error and update inside Firefox dev tools. @Elchi3, any thought (not urgent).

If so, we should contact the Firefox doc team.

Let's keep this open until @elchi3 come back to us.

teoli2003 avatar Jul 22 '22 05:07 teoli2003

Looks like this was changed in Firefox and I never made the doc update. See https://bugzilla.mozilla.org/show_bug.cgi?id=1339895 for context.

Elchi3 avatar Aug 16 '22 15:08 Elchi3

How should this progress though? Should we delete the page? Do we need to notify the Firefox team?

Josh-Cena avatar Aug 27 '22 15:08 Josh-Cena

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 01 '23 01:02 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 25 '23 22:02 github-actions[bot]

Looks like https://github.com/mdn/content/pull/24869 already addresses the same problem, but we still need to move the entire explanation to a new error page.

Josh-Cena avatar Feb 25 '23 22:02 Josh-Cena

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Mar 03 '23 11:03 github-actions[bot]

I'm going to close this PR for now, as the immediate motivation for the linked issue is already fixed. I'll investigate the latest state of Firefox syntax errors later, but syntax errors are the hardest to experiment, because there could be infinitely many cases.

Josh-Cena avatar Mar 29 '23 20:03 Josh-Cena