content icon indicating copy to clipboard operation
content copied to clipboard

Add length limitation for description member

Open AnilSeervi opened this issue 3 years ago • 5 comments

Summary

  • Add length limitation for description member

Motivation

Open-source

Supporting details

https://developer.chrome.com/docs/extensions/mv3/manifest/description/

Related issues

Fixes #11961

Metadata

  • [ ] Adds a new document
  • [x] Rewrites (or significantly expands) a document
  • [ ] Fixes a typo, bug, or other error

AnilSeervi avatar Jan 15 '22 15:01 AnilSeervi

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/description Title: description on GitHub

No new external URLs

(this comment was updated 2022-08-01 17:33:27.700297)

github-actions[bot] avatar Jan 15 '22 15:01 github-actions[bot]

@AnilSeervi This PR is waiting on your response to https://github.com/mdn/content/pull/12033#pullrequestreview-857201342

sideshowbarker avatar Jul 12 '22 06:07 sideshowbarker

I don't believe these limits are the same across browsers.

I would suggest either finding out what are limits in Firefox/Safari/... or more simply just note that browsers might impose different limits for this field.

I couldn't find anything on the length of description member apart from chrome docs. let us know if you've come across any such docs.

AnilSeervi avatar Jul 12 '22 08:07 AnilSeervi

@AnilSeervi to move this forward I would suggest you follow the advice from @zombie and "note that browsers might impose different limits for this field"

rebloor avatar Jul 27 '22 19:07 rebloor

@AnilSeervi I have approve this. We're waiting on @zombie to review and clear his change requested flag

rebloor avatar Aug 03 '22 17:08 rebloor