browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

Add missing statements for webview_ios

Open RupertBenWiser opened this issue 1 year ago • 4 comments

I tried to generate web-features locally using WebViews as part of the browser set.

I found that there were a few keys that webview_ios wasn't set for.

As far as I can see, in each of the places it was missing it was set as mirror for other keys for those elements.

RupertBenWiser avatar Oct 07 '24 12:10 RupertBenWiser

Leaving this open for the moment, will return to it. I will just flag that there are a few places like this that will mean we can't run baseline for WebViews yet.

RupertBenWiser avatar Oct 07 '24 15:10 RupertBenWiser

@RupertBenWiser Can you share the script? The few test failures may be caused by cases where the parent feature is not mirrored, and in those cases you could copy the version from the parent feature.

caugner avatar Oct 07 '24 16:10 caugner

@RupertBenWiser Do you have any concerns with merging this? Here are the effective changes:

image
(Text version)
version = "1+"
  html.elements.link.rel               .webview_ios
  html.elements.meta.http-equiv.refresh.webview_ios

version = "2+"
  html.elements.del.cite     .webview_ios
  html.elements.del.datetime .webview_ios
  html.elements.fieldset.form.webview_ios
  html.elements.iframe.height.webview_ios
  html.elements.iframe.name  .webview_ios
  html.elements.iframe.width .webview_ios
  html.elements.ins.cite     .webview_ios
  html.elements.ins.datetime .webview_ios

caugner avatar Jan 08 '25 16:01 caugner

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

github-actions[bot] avatar Jun 02 '25 16:06 github-actions[bot]

It looks like all the changes proposed in this PR have now been applied in other PRs, thus making this an empty PR. As such, I'm going to go ahead and close it as resolved!

queengooborg avatar Jun 24 '25 04:06 queengooborg