browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

Update Chromium data for optional_permissions Web Extensions manifest property

Open queengooborg opened this issue 1 year ago • 7 comments

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the optional_permissions Web Extensions manifest property. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing true values with ranged values to eliminate true values from BCD.

This PR uses the source code and commit history of Chrome to add specific version numbers, rather than just ranges. Details for each feature and the commit the version number chosen is available in the commit messages for this PR.

queengooborg avatar Aug 10 '24 09:08 queengooborg

I've now tagged all of the PRs that remove "true" and "null" with the "KR: Real Values" tag. @rebloor, if you could prioritize reviewing those PRs over the other ones I've opened (and am opening), that would be most appreciated!

queengooborg avatar Sep 04 '24 10:09 queengooborg

@queengooborg could you explain your sources? For example, why is nativeMessaging marked as Chrome 27. (The only reference here is to a Firefox related PR.)

rebloor avatar Sep 04 '24 23:09 rebloor

The commits for each of the features have the infomation for the sources used -- check each commit to find out more!

queengooborg avatar Sep 05 '24 00:09 queengooborg

@queengooborg these should go to someone more familiar with the Chrome repos, I think @dotproto should be able to help.

rebloor avatar Oct 01 '24 22:10 rebloor

Maybe @Rob--W could help. I know that's the Firefox team but I know Rob has looked into the timing of Chromium feature freezes and browser version releases a lot recently when reviewing https://github.com/mdn/browser-compat-data/pull/24279#issuecomment-2384682053

danielhjacobs avatar Oct 05 '24 15:10 danielhjacobs

Maybe @Rob--W could help. I know that's the Firefox team but I know Rob has looked into the timing of Chromium feature freezes and browser version releases a lot recently when reviewing https://github.com/mdn/browser-compat-data/pull/24279#issuecomment-2384682053

Thanks for tagging me. I have quite a bit of background there because I used to contribute to Chromium before, years before joining Mozilla to work on Firefox, which is useful to pinpoint the exact version where a feature was introduced. I'll post a review for one specific permission, and encourage current Google people to verify the accuracy of the updated PR (e.g. @oliverdunk, who is a devrel of Chrome extension).

Rob--W avatar Oct 05 '24 19:10 Rob--W

@queengooborg, does this feedback apply to all the other Chrome version updates PRs? If it does and you would like me to check them, could you please lay out the determination of the version number in a similar way to Rob's approach so I can check without redoing from scratch? Otherwise I'll leave for the folks from Google to review.

rebloor avatar Oct 06 '24 14:10 rebloor

FYI @rebloor @Rob--W I have discussed the Chrome WebExt PRs with @queengooborg today, and we aligned on the following:

  1. I will review the PRs, spot-checking that the data aligns with the sources given in the commit message.
  2. To double-check all features where true was replaced with a specific version number, I will create an issue with a task list.
  3. For all features where a range (esp. ≤58) was replaced with a specific version, we assume that the specific version is more helpful than the range, even if it isn't fully accurate due some features only landing in "dev", and shipping in "stable" later.

When merging these PRs, I will make sure to include the limitation in the commit message.

caugner avatar Nov 15 '24 10:11 caugner