browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

sync_event is experimental like SyncEvent and SyncManager

Open sidewayss opened this issue 1 year ago • 3 comments

The docs say the ServiceWorkerGlobalScope "sync" event is type SyncEvent and depends on SyncManager, and both of those are experimental technology, so the "sync" event must be experimental too.

sidewayss avatar Feb 01 '24 21:02 sidewayss

per https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#setting-experimental, the Background Sync API could be mark as non-experiment, as they are supported by at least one platform and for more then two years (in fact it is eight years).

skyclouds2001 avatar Feb 02 '24 06:02 skyclouds2001

By that logic SyncEvent and SyncManager should not be labeled experimental. I'm fine with that, so long as these 3 items are in sync, so to speak.

sidewayss avatar Feb 02 '24 15:02 sidewayss

Yes, you can change this PR to label both SyncEvent and SyncManager (and ServiceWorkerRegistration.sync) are not experimental

skyclouds2001 avatar Feb 03 '24 13:02 skyclouds2001

Yes, per the BCD guidelines, these features should be marked as non-experimental. @sidewayss, would you be down to change this PR (or create a new one) to mark SyncEvent and SyncManager as non-experimental instead?

queengooborg avatar Mar 04 '24 06:03 queengooborg

@sidewayss, would you be down to change this PR (or create a new one) to mark SyncEvent and SyncManager as non-experimental instead?

Sure, I'll try to get to it later today.

sidewayss avatar Mar 04 '24 13:03 sidewayss

I modified this branch to remove my original change and make SyncEvent and SyncManager not experimental. I removed the experimental property from the SyncEvent constructor, but I'm not sure which other properties/methods of both of these to mark as non-experimental. That will require some review from you, @queengooborg. Feel free to make whatever changes those are and merge, otherwise tell me and I'll make them. Thanks.

sidewayss avatar Mar 05 '24 14:03 sidewayss

ServiceWorkerRegistration.sync can also mark as non-experimental, too

skyclouds2001 avatar Mar 05 '24 15:03 skyclouds2001

I have tagged ServiceWorkerRegistration.sync as not experimental.

sidewayss avatar Mar 06 '24 13:03 sidewayss