browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

`notes` to `impl_url` property migration leftovers

Open mfranzke opened this issue 9 months ago • 1 comments

          > This was actually already handled in #20608!

There are some leftovers existing in the codebase.

Originally posted by @mfranzke in https://github.com/mdn/browser-compat-data/issues/20794#issuecomment-1732329990

This PR converts various implementation notes into impl_url keys instead, which would allow for better machine readability if needed ("See bug XXXXX" have been migrated with https://github.com/mdn/browser-compat-data/pull/20608 already).

This change was primarily performed by the following regex and manually going through the results afterwards and analyzing for phrases that haven't been catched with the changes out of https://github.com/mdn/browser-compat-data/pull/20608): "notes":\s*"(\S|\s)+(https:\/\/(crbug\.com(\/[^\/]+)?|bugzil\.la|webkit\.org\/b))

mfranzke avatar Sep 23 '23 14:09 mfranzke

@mfranzke how can we find the remaining cases? The regexp you posted doesn't work with git grep -E.

foolip avatar Feb 15 '24 04:02 foolip

@mfranzke how can we find the remaining cases? The regexp you posted doesn't work with git grep -E.

sorry, I should have mentioned this (and just adapted it to this issues description): It's a regex that works in VS Code search.

mfranzke avatar Feb 24 '24 20:02 mfranzke

I've only found one remaining occurance: https://github.com/mdn/browser-compat-data/pull/22287

mfranzke avatar Feb 24 '24 21:02 mfranzke

Closing as that was the last one then. Thanks @mfranzke 🙏

foolip avatar Feb 25 '24 01:02 foolip