browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

Addition of missing devtools details

Open rebloor opened this issue 1 year ago • 13 comments

Summary

Add details, previously missing for devtools features not supported in Firefox

Related issues

  • PR https://github.com/mdn/content/pull/28132 containing the Extend the developer tools article update
  • PR https://github.com/mdn/content/pull/28131 containing complementary updates to complete devtools.inspectedWindow documentation coverage
  • PR https://github.com/mdn/content/pull/28223 containing complementary update to complete devtools.network documentation coverage

Fixes #16859

rebloor avatar Jul 23 '23 10:07 rebloor

@Rob--W

Question: why are some features of edge not a mirror of Chrome?

Because I missed updating them from the copied content. I will fix that.

rebloor avatar Jul 27 '23 23:07 rebloor

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Oct 27 '23 12:10 github-actions[bot]

Hey @Rob--W, looks like this has been waiting on your review for a while!

queengooborg avatar Nov 07 '23 11:11 queengooborg

While I'm not against adding explicit entries for API support statuses in the BCD, the BCD also link to MDN documentation that haven't been merged yet.

I am reluctant to merge these MDN articles, because they document Chrome-only behavior. It's my intent to revisit these PRs eventually, but it's a low priority for me.

Rob--W avatar Nov 07 '23 16:11 Rob--W

Should we try to get a Chrome reviewer for this one?

Elchi3 avatar Nov 10 '23 14:11 Elchi3

That's not necessary. I am familiar with this API in both Firefox and Chrome.

The difficulty here is presenting the content in a way such that it is obvious which parts are cross-browser and which ones are Chrome-only. The current documentation lists the least common denominator, so anyone who relies on that can build an extension that works across browsers.

If we add the Chrome-specific bits here as well, then I'm concerned that an extension dev would try out the documentation and then become disappointed when they discovered that the documented features don't actually work in Firefox.

Rob--W avatar Nov 10 '23 20:11 Rob--W

I think that so long as the browser compatibility data is up to date, then we should be fine on that front. Web extensions don't have a standard specification that we can refer to, so since browsers are free to implement what they want to, I wouldn't expect much cross-browser support anyways.

queengooborg avatar Nov 11 '23 00:11 queengooborg

Also addresses https://github.com/mdn/browser-compat-data/issues/16859

rebloor avatar Nov 13 '23 03:11 rebloor

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Mar 08 '24 16:03 github-actions[bot]

This PR has been sitting around in need of a review for a while, and is the second oldest PR open. We should get this reviewed and landed, or close it!

queengooborg avatar May 11 '24 15:05 queengooborg

I think that it is okay for BCD notes to be added, even without mdn documentation. @rebloor could you update the PR and tag dotproto for review? If there is anything that requires my attention, please pm me.

Rob--W avatar May 12 '24 18:05 Rob--W

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Aug 04 '24 21:08 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Aug 09 '24 03:08 github-actions[bot]