browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

Update bgcolor HTML attribute

Open queengooborg opened this issue 3 years ago • 3 comments

This PR updates the data for the bgcolor HTML attribute, which fixes #17310. The version numbers come from other instances of the property, and confirmed by testing the oldest possible browsers in BrowserStack.

queengooborg avatar Aug 19 '22 11:08 queengooborg

This PR updates the data for the bgcolor HTML attribute, which fixes #17310. The version numbers come from other instances of the property, and confirmed by testing the oldest possible browsers in BrowserStack.

Can you describe the testing done, with links to the tests where possible? If "other instances of the property" means trusting the data from api.HTML*Element.bgcolor, then it would be good to spell out this assumption. It will often be the case that the content attribute is supported before the script property.

foolip avatar Aug 23 '22 07:08 foolip

Can you describe the testing done, with links to the tests where possible?

The test code is actually in the issue description!

queengooborg avatar Sep 11 '22 21:09 queengooborg

I see, https://codepen.io/estelle/pen/PoRdJaO then? That's only testing <thead bgcolor> and doesn't lend support to most of the changes being made then.

foolip avatar Sep 12 '22 11:09 foolip

Here's an updated example that shows the attribute working on other elements: https://codepen.io/queengooborg/pen/QWrYaXg

queengooborg avatar Oct 13 '22 16:10 queengooborg

OK, so given http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10877 some of the data could be set to Opera 12.1, but the current data isn't wrong, so let's go.

foolip avatar Oct 24 '22 13:10 foolip