browser-compat-data icon indicating copy to clipboard operation
browser-compat-data copied to clipboard

Published 20 hours ago • verified publisher icon mdn

Web Extensions Declarative Net Request WIP

Open jdatapple opened this issue 3 years ago • 10 comments

Summary

A work in progress branch for adding Declarative Net Request API and manifest support for Web Extensions.

jdatapple avatar Feb 11 '22 23:02 jdatapple

I've run this by @Elchi3, who suggested I flag @rebloor to take a look at this proposal. There is work to do on getting MDN URLs and obviously the browser data itself. This WIP is intended to propose a BCD structure to track the various elements of the API and Web Extensions Manifest declarations.

jdatapple avatar Feb 11 '22 23:02 jdatapple

Looks alright to me but would appreciate if @rebloor, @Rob--W or @rpl would take a look since I don't know WebExtensions all that well :)

Elchi3 avatar Feb 14 '22 10:02 Elchi3

It's a little difficult to comment without some context on this. Also, have you run npm test and confirmed that it has reported no errors.

rebloor avatar Feb 16 '22 02:02 rebloor

@Rob--W would you mind to provide some feedback on this? (in its current form it is mainly a skeleton of the structure meant to track DeclarativeNetRequest implementation across browser vendors, while the version values associated to each browser are not yet populated).

rpl avatar Feb 16 '22 11:02 rpl

Here's some feedback on the structure. It probably makes sense to do a full review once the version compatibility info is added + MDN docs are ready for review too.

I believe 1ca88f3 addresses your feedback. Is this ready enough for me to start collecting browser data?

jdatapple avatar Jun 24 '22 16:06 jdatapple

@Rob--W or @queengooborg any other feedback on this so that we can continue to make progress?

jdatapple avatar Jul 27 '22 16:07 jdatapple

I happened to notice that every single feature here has no implementation yet. We've actually implemented a policy not to include features with no support in any browser in BCD to reduce clutter. Are these features going to be implemented in Safari or other browsers? Also, is this PR still planned?

queengooborg avatar Aug 27 '22 01:08 queengooborg

I happened to notice that every single feature here has no implementation yet. We've actually implemented a policy not to include features with no support in any browser in BCD to reduce clutter. Are these features going to be implemented in Safari or other browsers? Also, is this PR still planned?

What lead to the conclusion that these features have no implementation?

There is an implementation in Chrome and Safari. And at the rate that the PR progresses, there may even be an implementation in Firefox when the PR+docs completes.

Rob--W avatar Aug 30 '22 01:08 Rob--W

What lead to the conclusion that these features have no implementation?

In this PR, every feature added is set to false for all browsers. I realize that there's been comments that clarify there's support; my apologies!

Since this PR has been sitting around for a long time, though, would you be down to create a new PR to supersede this one, @Rob--W?

queengooborg avatar Aug 30 '22 01:08 queengooborg

Since this PR has been sitting around for a long time, though, would you be down to create a new PR to supersede this one, @Rob--W?

Despite the lack of visible progress on the PR, the PR has not been forgotten. Once the supported features have been clarified, and documentation for MDN is ready, I would expect more progress here.

If somehow the PR hasn't finished when Firefox's implementation ships, then I may consider taking over. But for now I think the PR is in good hands.

Rob--W avatar Aug 30 '22 07:08 Rob--W

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions[bot] avatar Feb 14 '23 22:02 github-actions[bot]

This PR can be closed, because it has been superseded by #18403.

Rob--W avatar Feb 14 '23 22:02 Rob--W