Sometimes it never stops [Processing] even though it's done.

[chrisfromredfin]

Looking at the code, near line 120 of scrape.js, I console.log'd the sidebar.scrollTop and sidebar.offsetHeight, and sidebar.scrollHeight and I see the following values:

scrape.js:120: 1402.5 705 2108

Unfortunately 1402.5 + 705 = 2107.5 and so is not >= 2108.

What's the right thing here?

Original: let finished = (sidebar.scrollTop + sidebar.offsetHeight) >= sidebar.scrollHeight;

let finished = (Math.ceil(sidebar.scrollTop) + Math.ceil(sidebar.offsetHeight)) >= sidebar.scrollHeight; -or- let finished = Math.ceil(sidebar.scrollTop + sidebar.offsetHeight) >= sidebar.scrollHeight; -or- let finished = Math.ceil(sidebar.scrollTop + sidebar.offsetHeight) >= sidebar.scrollHeight - 1;

??

[jurgenhaas]

I'm seeing that as well, sometimes. It seems to be more likely to happen on longer threads. And when it does, the trailing </table> is missing. No big deal to add this manually. If it helps I could probably provide a link to a thread where this happens and can be reproduced.

[chrisfromredfin]

FWIW I've been rolling with

let finished = Math.ceil(sidebar.scrollTop + sidebar.offsetHeight) >= sidebar.scrollHeight;

And it's been flawless for me. I'll open a PR.

[seantwalsh]

@chrisfromredfin thanks for this working for me as well.

[mdlutz24]

Merged, thanks!