wifi icon indicating copy to clipboard operation
wifi copied to clipboard

Add methods to retrieve physical device information

Open dhduvall opened this issue 5 years ago • 4 comments

This is functionality I need for my work, but it needs some checking. I'm happy to rename and re-type things. There's one XXX comment that should probably be addressed. There's also plenty of PHY-related stuff that I didn't add because I didn't need it and I didn't want to go too far down the rabbit-hole until I knew I was going down the right one.

dhduvall avatar Jul 31 '18 16:07 dhduvall

Thanks for the PR. I'm a bit busy at work this week but I'll try to get to this if I have some free time in the next couple of days.

mdlayher avatar Jul 31 '18 16:07 mdlayher

One thing I'm unsure about (and more so now that I'm looking at adding the VHT bits) is whether the A-MPDU members I stuck in BandAttributes really belong there instead of in HTCapabilities. Right now, HTCapabilities is a representation of the 16-bit HT Capabilities structure in the frame (and how precisely the kernel relates that to the configuration-like bits that we get in userland over netlink, I don't know, and I never got a response to that from the linux-wireless list), but that's somewhat by accident, because I created the structs to match the netlink attribute structure, which may not be the best thing to follow. AFAICT, those A-MPDU members are really HT-specific; there are similar ones for VHT, but rather than being communicated over netlink as separate attributes, they're just bits in the VHT Capabilities bitset.

I'd be okay with simply pulling them out (or making them private) for now, if that's more comfortable, since I don't need them.

dhduvall avatar Aug 02 '18 22:08 dhduvall

I think I'm done twiddling on this. I've also got VHT changes nearly ready to go.

dhduvall avatar Aug 17 '18 21:08 dhduvall

Any status on merging this pull request?

henrikkorsgaard avatar Oct 03 '18 07:10 henrikkorsgaard

This needs a rebase.

SuperQ avatar Jun 14 '23 12:06 SuperQ

Closing as stale. Anyone seeing this is welcome to open a new PR with a rebase.

SuperQ avatar Nov 01 '23 16:11 SuperQ