ethtool icon indicating copy to clipboard operation
ethtool copied to clipboard
verified publisher icon mdlayher

Add support for updating linkmodes

Open nwaples opened this issue 1 year ago • 1 comments

I noticed the previous PR for updating link modes was old, so I created a new request based off that. It is different in that I didnt implement updating LinkMode.Ours directly. Instead I added an Advertise option which implements what the ethtool command line option advertise does.

nwaples avatar Jan 15 '25 05:01 nwaples

The slices package is old enough that I think we should update the go minimum in go.mod to 1.21 to support it.

SuperQ avatar Jan 17 '25 08:01 SuperQ

I have updated the Go minimum version to 1.23.0.

SuperQ avatar Apr 07 '25 16:04 SuperQ

You can drop commit 98aebd36ff5682020ab8d1df882c4af368ccd5d4 from your PR, since we now support the slices package.

SuperQ avatar Apr 08 '25 05:04 SuperQ

It looks like you have incorrectly rebased your main branch.

I highly recommend looking at fork and branch workflow to avoid this kind of issue.

SuperQ avatar Apr 08 '25 07:04 SuperQ

I noticed the previous PR for updating link modes was old, so I created a new request based off that. It is different in that I didnt implement updating LinkMode.Ours directly. Instead I added an Advertise option which implements what the ethtool command line option advertise does.

Yep thanks. Created a new PR. Hopefully wont screw it up as bad again.

nwaples avatar Apr 08 '25 09:04 nwaples