moodle-mod_customcert icon indicating copy to clipboard operation
moodle-mod_customcert copied to clipboard
verified publisher icon mdjnelson

Issue #531: Email task performance improvements and time limit

Open Peterburnett opened this issue 2 years ago • 3 comments

Closes #531

Peterburnett avatar Jan 19 '24 06:01 Peterburnett

Hi @mdjnelson, just checking in on this one, and if you had any feedback. I can deploy on a fork, but I would rather not where it can be avoided.

It would be ideal if I could include this in my next client deployment in 2-3 weeks

Peterburnett avatar Feb 07 '24 01:02 Peterburnett

Sorry @Peterburnett i've been focusing on other issues and am free to look now. Also, please see there is another improvement for this at https://github.com/mdjnelson/moodle-mod_customcert/pull/610. Feel free to have a look and comment with what you think. :)

mdjnelson avatar Mar 13 '24 08:03 mdjnelson

Hi Peter,

I don't think it is safe to assume just because the user accessed the course after the last time the task was run that they would have necessarily downloaded the certificate.

What are your thoughts?

mdjnelson avatar Mar 13 '24 12:03 mdjnelson

Closing this in favour of https://github.com/mdjnelson/moodle-mod_customcert/pull/610 and due to my comments above.

mdjnelson avatar May 23 '24 12:05 mdjnelson