moodle-mod_customcert
moodle-mod_customcert copied to clipboard
mdjnelson
Background image no longer working
Attached is the background that I am using. I also sent a picture of my template as I was editing and you can see where it moved out of the normal position. When I start editing the position will be correct. Then when I go to view the certificate and come back to edit a couple times it will move all of the elements including the background as seen below.
Is it that the background image moves or the other elements move? My background image seems to be just fine but the other elements do not display in the position they are set to when editing. They all move slightly.
It appears to me that the entire certificate is moving. When I go into the elements some of them at the top of the certificate have negative values in the position.
Eric
On May 26, 2020, at 8:28 AM, emmarichardson [email protected] wrote:
Is it that the background image moves or the other elements move? My background image seems to be just fine but the other elements do not display in the position they are set to when editing. They all move slightly.
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-634024736, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZANPJDK7TBLHYAM5MLRTO7W7ANCNFSM4KSBWNDA.
I can not replicate this, even with the image provided. It looks and works fine for me. I think this is a theme issue. Has anyone tried changing their theme to 'Classic' or 'Boost' temporarily and seeing if that fixes the problem?
I tried it on Adaptable, Boost and Classic and had the same issue. It seems like it is not placing the background in the square that appears when you set the size. Therefore everything is shifted up about 14-20 units. As you can see below the buttons "save and close" "save and continue" are not visible. in pic #2 Pics below are in the Classic Theme.
II have been playing around with this for some time and can not replicate it. I added a grade and code element and moved them around and kept re-visiting the reposition page in both Boost and Classic and there were no issues.
It is not that the items don’t move around - it is that they do not then preview in the place that you place them...
Emma
On Oct 12, 2020, 6:50 AM -0600, Mark Nelson [email protected], wrote:
II have been playing around with this for some time and can not replicate it. I added a grade and code element and moved them around and kept re-visiting the reposition page in both Boost and Classic and there were no issues. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.
Can you tell me what width and height you have set for that page of the certificate?
279 and 216
Emma
Emma Richardson Distance Learning Coordinator Direct: 719-650-3037 On Oct 14, 2020, 10:44 AM -0600, Mark Nelson [email protected], wrote:
Can you tell me what width and height you have set for that page of the certificate? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.
Width 280 Height 215
Eric Foster Builders Academy Houston, TX 281-558-4100
From: Mark Nelson [email protected] Sent: Wednesday, October 14, 2020 11:44 AM To: mdjnelson/moodle-mod_customcert [email protected] Cc: Eric Foster [email protected]; Comment [email protected] Subject: Re: [mdjnelson/moodle-mod_customcert] Background image no longer working (#323)
Can you tell me what width and height you have set for that page of the certificate?
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-708524359, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZA7MQQGAKE6ZTQT54DSKXINPANCNFSM4KSBWNDA.
Now that I have started working with the certificates more, it appears the issue arises while trying to set up the templates for the certificates to be used in multiple classes.
Eric Foster Builders Academy Houston, TX 281-558-4100
From: Mark Nelson [email protected] Sent: Wednesday, October 14, 2020 11:44 AM To: mdjnelson/moodle-mod_customcert [email protected] Cc: Eric Foster [email protected]; Comment [email protected] Subject: Re: [mdjnelson/moodle-mod_customcert] Background image no longer working (#323)
Can you tell me what width and height you have set for that page of the certificate?
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-708524359, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZA7MQQGAKE6ZTQT54DSKXINPANCNFSM4KSBWNDA.
Chrome
Eric
On Nov 25, 2020, at 7:46 AM, Mark Nelson [email protected] wrote:
What browser are you all using?
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-733715774, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZGPD3ODTXNDGBOQ6YLSRUDEDANCNFSM4KSBWNDA.
Hm, same. I also set my width to 280 and height to 215, added a BG image, a normal image and when I press 'Save and continue' on the reposition page the images remain where they are and the buttons are not hidden by them.
See above. This is what I have. Are you running the latest 3.8 on github, or did you download from the plugins DB?
Version 3.8 from GitHub. Mine will start out in the correct position but then after I start adding more information ( sometimes 8-10 items) to the template it will then move everything up.
Eric
On Nov 25, 2020, at 7:57 AM, Mark Nelson [email protected] wrote:
See above. This is what I have. Are you running the latest 3.8 on github, or did you download from the plugins DB?
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-733721764, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZHDFTSXAX7M6UJRDFLSRUEMNANCNFSM4KSBWNDA.
I have had someone work on this issue and it seems they found a solution. I would like to send the files to you so you can find what they came up with. I just need to know how to get them to you.
Could they sign up to Github and put the solution in this comment section?
Thanks. It would be preferable to see just the changes that were done (in a patch) but I can do a diff and see what the differences are.
Thanks. It would be preferable to see just the changes that were done (in a patch) but I can do a diff and see what the differences are.
Hey Mark.
I've not had any involvement but have been watching this issue; I tried comparing the uploaded ZIP to help out but didn't have much luck.
It appears the developer added three lines to the savepositions function in rearrange-debug.js and rearrange.js
window.scrollTo(0, 0);
document.querySelector("body").style.height = '100%';
document.querySelector("body").style.overflow = 'hidden';
Commented out the whole of rearrange-min.js and replaced it's usage by writing the JS manually in rearrange.php This appears to be a full re-write rather than one or two small changes. I think if you can read what they wrote in rearrange.php line 135+ you might recognise something immediately different.
I was hoping originally to save you from the workload, but there is so much JS named slightly differently I didn't want to muddy the situation further.
Thanks for your hard work with this fantastic plugin!
@EFoster1068 are you able to provide a diff with the changes, or create a merge request?
I have never tried to do that.
Eric
On Mar 25, 2021, at 8:15 AM, Mark Nelson @.***> wrote:
@EFoster1068https://github.com/EFoster1068 are you able to provide a diff with the changes, or create a merge request?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mdjnelson/moodle-mod_customcert/issues/323#issuecomment-806720735, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOSV2ZBSMVB23E7SZEXYRTTTFMZNTANCNFSM4KSBWNDA.