Milos Djermanovic

Results 652 comments of Milos Djermanovic

> Here is [the line](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/d51a197067b1d09e72de0ff6388ff8a09ebd3742/test/utils/snapshot-rule-tester.mjs#L187) I use it, I've linked in the description. > > Update: I'm sorry that I forgot to mention this is request to assert output for...

@fisker we're trying to figure out if this is a blocker for v8.0.0. Could you please try this solution: https://github.com/eslint/eslint/issues/14936#issuecomment-905377189 and tell us whether or not it works for your...

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/d51a197067b1d09e72de0ff6388ff8a09ebd3742/test/utils/snapshot-rule-tester.mjs#L187 ```diff - const {output} = SourceCodeFixer.applyFixes(code, [suggestion]); + const { fix } = suggestion; + const output = `${code.slice(0, fix.range[0])}${fix.text}${code.slice(fix.range[1])}`; ```

> I made a minimal gist for trying the RuleTester in ESLint 8 with Jest: https://gist.github.com/lydell/d62ce96c95c035811133a5396195da14 > > It doesn’t work. Probably Jest’s fault? Not sure what to do with...

We could add an option in ReferenceTracker to return only certain references, or maybe change the rule to not use ReferenceTracker and manually find a smaller set of references. @mysticatea...

@ota-meshi thanks! Marked as accepted. It seems we're just waiting for `regexpp`.

Just to clarify the issue, I believe this configuration expects something like: ```js /* eslint func-style: [2, "expression"] */ export const foo = function () {}; ``` What conflict does...

So, the motivation is to allow hoisting only for exported functions because good practice is to define all exports at the end? ```js foo(); // this wouldn't be possible here...

> Unfortunately that does result in hoisting, but in this case I don't care about it, because i don't want to create an extra variable in my named exports. I'm...