gradle-offline-dependencies-plugin icon indicating copy to clipboard operation
gradle-offline-dependencies-plugin copied to clipboard

[Enhancement] Compat gradle plugin "com.android.tools.build:gradle:3.3.0” in android studio 3.3.

Open Guang1234567 opened this issue 6 years ago • 5 comments

Guang1234567 avatar Jan 24 '19 04:01 Guang1234567

Hello dev:

Could you compat gradle plugin com.android.tools.build:gradle:3.3.0 in android studio 3.3 ? And my gradle version is 4.10.1.

I met below error that not happen in com.android.tools.build:gradle:3.1.2 in android studio 3.1.4 :

Unable to load class 'org.gradle.api.internal.CollectionCallbackActionDecorator’.

Guang1234567 avatar Jan 24 '19 04:01 Guang1234567

Hello dev:

I fix it by upgrade gradle to v5.1.

https://github.com/mdietrichstein/gradle-offline-dependencies-plugin/commit/7b5c099664bcb2d915b7545836f7d470d9711f27

BTY, thanks your plugin.

Guang1234567 avatar Jan 24 '19 04:01 Guang1234567

As org.gradle.api.internal.CollectionCallbackActionDecorator was added with gradle 5.1, this effectively means, that this latest version is only usable with gradle 5.1+.

Is this intended or an oversight?

adude3141 avatar Jan 25 '19 00:01 adude3141

@adude3141

I don’t know. Gradle4.10 is the default config in Android Studio 3.3 that pass large test (maybe). So I will not change gradle version as a general rule. But sometime default gradle version maybe not work with your plugin unfortunately. ^_^

Guang1234567 avatar Jan 25 '19 07:01 Guang1234567

Yes, of course.

But on the other hand, their might be constraints which prevent upgrading your project to gradle 5.1.

It might be intended, but as the docs still state the plugin to be compatible with gradle 2.1 I was wondering whether this is only an oversight and need to be fixed?

FYI @mdietrichstein

adude3141 avatar Jan 25 '19 11:01 adude3141