Mark Dickinson

Results 260 comments of Mark Dickinson

I left a few comments on the code, mostly (but not entirely) at nitpick level. > * it is a subclass of `TestCase` rather than a mixin (I could be...

N.B. I didn't really look at the parts of this PR that aren't directly related to the `GuiTestCase`.

This may not be entirely specific to Wx: I witnessed the segfault with Wx, but if the circular references are there in the Qt implementation too then those could potentially...

On a desktop. Yes, it runs fine if I don't try to do anything else while the test suite is running. Can we make this more robust somehow? Or find...

Versions: Python 3.6.13 from EDM, Pyface 7.3.0-5, PyQt5 5.14.2-4, PyQt5-sip 12.7.2-1. I'll do some experimentation with other Qt wrappers.

This appears to be quite specific to the EDM runtime and Qt / PyQt versions. I can reproduce with the following EDM combinations: - Python 3.6.13, Pyface 7.4.0, PyQt5 5.14.2-4...

@Dzeri96 Thanks for opening the issue! There was a fair bit of confusion in #84813; it would be good to eliminate that confusion up front here. To clarify, when you...

@Dzeri96 Maybe a ping on https://discuss.python.org? I'm afraid that I'm not personally likely to have time to look at this this side of Christmas.

Thanks for the updates. It might be a few days before I have time to re-review; feel free to ping if you don't hear anything by mid-November. > Should I...

Using `.value` instead of `int` seems to work for this particular version of PySide6. (But it probably fails for other versions.) ```python >>> from pyface.qt import QtCore >>> QtCore.Qt.DockWidgetArea.LeftDockWidgetArea >>>...